core/fxcodec/jbig2/JBig2_GsidProc.cpp - Issue 1821423002: Re-enable MSVC warning 4702

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fxcodec/jbig2/JBig2_GsidProc.cpp

Issue 1821423002: Re-enable MSVC warning 4702 (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: address comments Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fxcodec/jbig2/JBig2_GsidProc.cpp

diff --git a/core/fxcodec/jbig2/JBig2_GsidProc.cpp b/core/fxcodec/jbig2/JBig2_GsidProc.cpp

index 92532d7238f6008cceda88f3f95caba0dd05f818..f1a566a5db65f456a1b78a785a7adbf4e976e028 100644

--- a/core/fxcodec/jbig2/JBig2_GsidProc.cpp

+++ b/core/fxcodec/jbig2/JBig2_GsidProc.cpp

@@ -96,10 +96,9 @@ FX_DWORD* CJBig2_GSIDProc::decode_MMR(CJBig2_BitStream* pStream,

pGRD->Continue_decode(pPause);

}

if (!GSPLANES.get()[J]) {

- for (int32_t K = GSBPP - 1; K > J; --K) {

+ for (int32_t K = GSBPP - 1; K > J; --K)

delete GSPLANES.get()[K];

- return nullptr;

- }

+ return nullptr;

}

pStream->alignByte();

pStream->offset(3);