Remove logic for lazy initialization of WebKit.

Remove logic for lazy initialization of WebKit.

See "Extensions impact on startup?" thread on (internal) chrome-fast mailing list from 8/14/2015 for background, which showed that effectively undoing this logic showed a 3% reduction on first_non_empty_paint_time. This lazy initialization used to be a performance win when it was added years ago, but has since become a performance drag. Since it's effectively not used now (since ChromeContentRendererClient::RenderThreadStarted always initializes WebKit through its call to RenderThread::RegisterExtension), just remove this unused logic.

Committed: https://crrev.com/75c4422d8fdabd231f40a6c9235f4512f0170268
Cr-Commit-Position: refs/heads/master@{#382795}

[jam, 2016-03-22 22:13:41]

Patchset #1 (id:1) has been deleted

[jam, 2016-03-22 22:19:47]

jam@chromium.org changed reviewers:
+ avi@chromium.org

[Avi (use Gerrit), 2016-03-23 00:10:39]

👍

Good riddance. LGTM

https://codereview.chromium.org/1821413003/diff/40001/content/renderer/render...
File content/renderer/render_thread_impl.cc (right):

https://codereview.chromium.org/1821413003/diff/40001/content/renderer/render...
content/renderer/render_thread_impl.cc:656:
InitializeWebKit(resource_task_queue);
Can we rename this to InitializeBlink while we're moving everything around?

https://codereview.chromium.org/1821413003/diff/40001/content/renderer/render...
content/renderer/render_thread_impl.cc:1229: void
RenderThreadImpl::InitializeWebKit(
s/WebKit/Blink/?

https://codereview.chromium.org/1821413003/diff/40001/extensions/renderer/dis...
File extensions/renderer/dispatcher.cc (right):

https://codereview.chromium.org/1821413003/diff/40001/extensions/renderer/dis...
extensions/renderer/dispatcher.cc:282: // WebKit was initialized.
s/WebKit/Blink/

[jam, 2016-03-23 00:15:00]

On 2016/03/23 00:10:39, Avi wrote:
> 👍
> 
> Good riddance. LGTM
> 
>
https://codereview.chromium.org/1821413003/diff/40001/content/renderer/render...
> File content/renderer/render_thread_impl.cc (right):
> 
>
https://codereview.chromium.org/1821413003/diff/40001/content/renderer/render...
> content/renderer/render_thread_impl.cc:656:
> InitializeWebKit(resource_task_queue);
> Can we rename this to InitializeBlink while we're moving everything around?
> 
>
https://codereview.chromium.org/1821413003/diff/40001/content/renderer/render...
> content/renderer/render_thread_impl.cc:1229: void
> RenderThreadImpl::InitializeWebKit(
> s/WebKit/Blink/?
> 
>
https://codereview.chromium.org/1821413003/diff/40001/extensions/renderer/dis...
> File extensions/renderer/dispatcher.cc (right):
> 
>
https://codereview.chromium.org/1821413003/diff/40001/extensions/renderer/dis...
> extensions/renderer/dispatcher.cc:282: // WebKit was initialized.
> s/WebKit/Blink/

good question. I thought about renaming it, but the rest of the files had
"webkit" so it seemed better to rename all the methods/variables at the same
time instead of the inconsistency of both blink and webkit.

[jam, 2016-03-23 04:11:20]

The CQ bit was checked by jam@chromium.org

[commit-bot: I haz the power, 2016-03-23 04:11:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1821413003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1821413003/40001

[commit-bot: I haz the power, 2016-03-23 05:34:34]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-03-23 05:35:49]

Description was changed from

==========
Remove logic for lazy initialization of WebKit.

See "Extensions impact on startup?" thread on (internal) chrome-fast mailing
list from 8/14/2015 for background, which showed that effectively undoing this
logic showed a 3% reduction on first_non_empty_paint_time. This lazy
initialization used to be a performance win when it was added years ago, but has
since become a performance drag. Since it's effectively not used now (since
ChromeContentRendererClient::RenderThreadStarted always initializes WebKit
through its call to RenderThread::RegisterExtension), just remove this unused
logic.
==========

to

==========
Remove logic for lazy initialization of WebKit.

See "Extensions impact on startup?" thread on (internal) chrome-fast mailing
list from 8/14/2015 for background, which showed that effectively undoing this
logic showed a 3% reduction on first_non_empty_paint_time. This lazy
initialization used to be a performance win when it was added years ago, but has
since become a performance drag. Since it's effectively not used now (since
ChromeContentRendererClient::RenderThreadStarted always initializes WebKit
through its call to RenderThread::RegisterExtension), just remove this unused
logic.

Committed: https://crrev.com/75c4422d8fdabd231f40a6c9235f4512f0170268
Cr-Commit-Position: refs/heads/master@{#382795}
==========

[commit-bot: I haz the power, 2016-03-23 05:35:50]

Patchset 2 (id:??) landed as
https://crrev.com/75c4422d8fdabd231f40a6c9235f4512f0170268
Cr-Commit-Position: refs/heads/master@{#382795}