Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2767)

Unified Diff: content/renderer/render_thread_impl_browsertest.cc

Issue 1821413003: Remove logic for lazy initialization of WebKit. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix test Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_thread_impl_browsertest.cc
diff --git a/content/renderer/render_thread_impl_browsertest.cc b/content/renderer/render_thread_impl_browsertest.cc
index 67bc93abd1d0ed32c8ea31765fda06196490eb02..f1b21a4f7c9e52edbd58a426ea71431532d962cc 100644
--- a/content/renderer/render_thread_impl_browsertest.cc
+++ b/content/renderer/render_thread_impl_browsertest.cc
@@ -101,24 +101,18 @@ class TestTaskCounter : public base::SingleThreadTaskRunner {
class RenderThreadImplForTest : public RenderThreadImpl {
public:
- RenderThreadImplForTest(const InProcessChildThreadParams& params,
- scoped_ptr<scheduler::RendererScheduler> scheduler,
- scoped_refptr<TestTaskCounter> test_task_counter)
- : RenderThreadImpl(params, std::move(scheduler)),
- test_task_counter_(test_task_counter) {}
+ RenderThreadImplForTest(
+ const InProcessChildThreadParams& params,
+ scoped_ptr<scheduler::RendererScheduler> scheduler,
+ scoped_refptr<base::SingleThreadTaskRunner>& test_task_counter)
+ : RenderThreadImpl(params, std::move(scheduler), test_task_counter) {
+ }
~RenderThreadImplForTest() override {}
- void SetResourceDispatchTaskQueue(
- const scoped_refptr<base::SingleThreadTaskRunner>&) override {
- // Use our TestTaskCounter instead.
- RenderThreadImpl::SetResourceDispatchTaskQueue(test_task_counter_);
- }
-
using ChildThreadImpl::OnMessageReceived;
private:
- scoped_refptr<TestTaskCounter> test_task_counter_;
};
#if defined(COMPILER_MSVC)
@@ -185,15 +179,15 @@ class RenderThreadImplBrowserTest : public testing::Test {
scoped_ptr<scheduler::RendererScheduler> renderer_scheduler =
scheduler::RendererScheduler::Create();
InitializeMojo();
+ scoped_refptr<base::SingleThreadTaskRunner> test_task_counter(
+ test_task_counter_.get());
thread_ = new RenderThreadImplForTest(
InProcessChildThreadParams(test_helper_->GetChannelId(),
test_helper_->GetIOTaskRunner(),
test_helper_->GetMessagePipeHandle()),
- std::move(renderer_scheduler), test_task_counter_);
+ std::move(renderer_scheduler), test_task_counter);
cmd->InitFromArgv(old_argv);
- thread_->EnsureWebKitInitialized();
-
test_msg_filter_ = make_scoped_refptr(
new QuitOnTestMsgFilter(test_helper_->GetMessageLoop()));
thread_->AddFilter(test_msg_filter_.get());

Powered by Google App Engine
This is Rietveld 408576698