Fix content/common depending on content/shell.

Fix content/common depending on content/shell.

Only browser tests in content/ should depend on content/shell. Fixed DEPS so that this doesn't happen again.

BUG=596736

[jam, 2016-03-22 16:46:00]

jam@chromium.org changed reviewers:
+ alexmos@chromium.org, creis@chromium.org

[jam, 2016-03-22 16:46:00]

context: https://codereview.chromium.org/1067373005

[jam, 2016-03-22 17:03:41]

Description was changed from

==========
Fix content/common depending on content/shell.

Only browser tests in content/ should depend on content/shell. Fixed DEPS so
that this doesn't happen again.
==========

to

==========
Fix content/common depending on content/shell.

Only browser tests in content/ should depend on content/shell. Fixed DEPS so
that this doesn't happen again.

BUG=596736
==========

[alexmos, 2016-03-22 17:16:06]

alexmos@chromium.org changed reviewers:
+ lukasza@chromium.org

[alexmos, 2016-03-22 17:16:07]

This makes sense to me, but I think lukasza@ should review this, since he also
started working on a fix for this exact issue.

[Łukasz Anforowicz, 2016-03-22 17:23:52]

On 2016/03/22 17:16:07, alexmos wrote:
> This makes sense to me, but I think lukasza@ should review this, since he also
> started working on a fix for this exact issue.

Right - I have a fix in progress at https://codereview.chromium.org/1777503003/.

I think messages specific to layout tests should be handled in the layout tests
layer (i.e. recently jochen@ suggested similar differentiation for cmdline
switches - see ).  And there are a few more DEPS tweaks in my CL (restrict
browser tests to only browser/common side of content/shell).

Overall - the current CL looks good, except I would like to defer to jochen@ for
content/shell VS content/shell/.../layout_tests layering review (or we can go
forward with https://codereview.chromium.org/1777503003).

[Łukasz Anforowicz, 2016-03-22 17:25:21]

+jochen@ to CC [for comparing this CL to the more strict content/shell VS
content/shell/.../layout_tests separation in
https://codereview.chromium.org/1777503003/]

[jam, 2016-03-22 19:36:14]

On 2016/03/22 17:23:52, Łukasz Anforowicz wrote:
> On 2016/03/22 17:16:07, alexmos wrote:
> > This makes sense to me, but I think lukasza@ should review this, since he
also
> > started working on a fix for this exact issue.
> 
> Right - I have a fix in progress at
https://codereview.chromium.org/1777503003/.
> 
> I think messages specific to layout tests should be handled in the layout
tests
> layer (i.e. recently jochen@ suggested similar differentiation for cmdline
> switches - see ).  And there are a few more DEPS tweaks in my CL (restrict
> browser tests to only browser/common side of content/shell).
> 
> Overall - the current CL looks good, except I would like to defer to jochen@
for
> content/shell VS content/shell/.../layout_tests layering review (or we can go
> forward with https://codereview.chromium.org/1777503003).

either is fine for me. let's land the other change please.