Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 1821123002: [intrinsics] Remove unused intrinsic %_IncrementStatsCounter. (Closed)

Created:
4 years, 9 months ago by Benedikt Meurer
Modified:
4 years, 9 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[intrinsics] Remove unused intrinsic %_IncrementStatsCounter. This was once meant to be used for JavaScript code stubs, but since we found a better way to do code stubs using TurboFan, we don't need this runtime entry and intrinsic anymore. R=jarin@chromium.org Committed: https://crrev.com/1d0df88b1116cec4726d9278358099b230fade24 Cr-Commit-Position: refs/heads/master@{#34976}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -66 lines) Patch
M src/compiler/js-intrinsic-lowering.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/js-intrinsic-lowering.cc View 2 chunks +0 lines, -27 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime-internal.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M test/cctest/compiler/test-run-intrinsics.cc View 1 chunk +0 lines, -25 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
4 years, 9 months ago (2016-03-22 06:02:37 UTC) #1
Benedikt Meurer
Hey Jaro, Here's the first step in cleaning up intrinsic lowering. Please take a look. ...
4 years, 9 months ago (2016-03-22 06:03:16 UTC) #2
Jarin
lgtm
4 years, 9 months ago (2016-03-22 06:04:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1821123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1821123002/1
4 years, 9 months ago (2016-03-22 06:04:31 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-22 06:34:17 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-22 06:35:51 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1d0df88b1116cec4726d9278358099b230fade24
Cr-Commit-Position: refs/heads/master@{#34976}

Powered by Google App Engine
This is Rietveld 408576698