Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2263)

Unified Diff: src/compiler/js-intrinsic-lowering.cc

Issue 1821123002: [intrinsics] Remove unused intrinsic %_IncrementStatsCounter. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/js-intrinsic-lowering.h ('k') | src/runtime/runtime.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/js-intrinsic-lowering.cc
diff --git a/src/compiler/js-intrinsic-lowering.cc b/src/compiler/js-intrinsic-lowering.cc
index 1765e4b3e8d108a0da4308ddd744fd4f4844dde6..e88426874486c53b91b4679cd5d89b106795f2a8 100644
--- a/src/compiler/js-intrinsic-lowering.cc
+++ b/src/compiler/js-intrinsic-lowering.cc
@@ -45,8 +45,6 @@ Reduction JSIntrinsicLowering::Reduce(Node* node) {
return ReduceDoubleHi(node);
case Runtime::kInlineDoubleLo:
return ReduceDoubleLo(node);
- case Runtime::kInlineIncrementStatsCounter:
- return ReduceIncrementStatsCounter(node);
case Runtime::kInlineIsArray:
return ReduceIsInstanceType(node, JS_ARRAY_TYPE);
case Runtime::kInlineIsTypedArray:
@@ -158,31 +156,6 @@ Reduction JSIntrinsicLowering::ReduceDoubleLo(Node* node) {
}
-Reduction JSIntrinsicLowering::ReduceIncrementStatsCounter(Node* node) {
- if (!FLAG_native_code_counters) return ChangeToUndefined(node);
- HeapObjectMatcher m(NodeProperties::GetValueInput(node, 0));
- if (!m.HasValue() || !m.Value()->IsString()) {
- return ChangeToUndefined(node);
- }
- base::SmartArrayPointer<char> name =
- Handle<String>::cast(m.Value())->ToCString();
- StatsCounter counter(jsgraph()->isolate(), name.get());
- if (!counter.Enabled()) return ChangeToUndefined(node);
-
- Node* effect = NodeProperties::GetEffectInput(node);
- Node* control = NodeProperties::GetControlInput(node);
- FieldAccess access = AccessBuilder::ForStatsCounter();
- Node* cnt = jsgraph()->ExternalConstant(ExternalReference(&counter));
- Node* load =
- graph()->NewNode(simplified()->LoadField(access), cnt, effect, control);
- Node* inc =
- graph()->NewNode(machine()->Int32Add(), load, jsgraph()->OneConstant());
- Node* store = graph()->NewNode(simplified()->StoreField(access), cnt, inc,
- load, control);
- return ChangeToUndefined(node, store);
-}
-
-
Reduction JSIntrinsicLowering::ReduceIsInstanceType(
Node* node, InstanceType instance_type) {
// if (%_IsSmi(value)) {
« no previous file with comments | « src/compiler/js-intrinsic-lowering.h ('k') | src/runtime/runtime.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698