Migrate a bunch of LayoutTests from NPAPI to PPAPI

Migrate a bunch of LayoutTests from NPAPI to PPAPI

- Add a way to specify extensions handled by plugins. Flash needs it, so we need to test the feature
- Fix PluginObject::EnumerateNamedProperties to correctly raise an exception when the object is deleted
- Remove a couple of tests that exercise NPAPI features that don't exist / we don't need on PPAPI (NPN_ReloadPlugins, using plugin to handle images)
- Add some extra API to blink_deprecated_test_plugin and port tests over.

BUG=318978, 474535
Committed: https://crrev.com/a7f9ca2dc86876b60a1080c5531336a8bea88b6f
Cr-Commit-Position: refs/heads/master@{#382929}

[piman, 2016-03-22 05:34:27]

piman@chromium.org changed reviewers:
+ dcheng@chromium.org

[piman, 2016-03-22 05:50:43]

Patchset #1 (id:1) has been deleted

[dcheng, 2016-03-22 18:03:05]

https://codereview.chromium.org/1821103002/diff/20001/content/common/pepper_p...
File content/common/pepper_plugin_list.cc (right):

https://codereview.chromium.org/1821103002/diff/20001/content/common/pepper_p...
content/common/pepper_plugin_list.cc:58: // mime-type-data = <mime-type> + *(
LWS + "#" + LWS + <extension> )
Nit: I think this should be *1, since there can only be one extension
associated?

https://codereview.chromium.org/1821103002/diff/20001/ppapi/tests/blink_depre...
File ppapi/tests/blink_deprecated_test_plugin.cc (right):

https://codereview.chromium.org/1821103002/diff/20001/ppapi/tests/blink_depre...
ppapi/tests/blink_deprecated_test_plugin.cc:131: "normalize",
Can we add add documentation about the various attributes/methods/properties
exposed by the test plugin to the file-level comment?

https://codereview.chromium.org/1821103002/diff/20001/ppapi/tests/blink_depre...
ppapi/tests/blink_deprecated_test_plugin.cc:318: }
Nit: newline.

https://codereview.chromium.org/1821103002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/permissionclient/plugin-permission.html
(right):

https://codereview.chromium.org/1821103002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/permissionclient/plugin-permission.html:37:
plugin.setAttribute("type", "application/x-blink-deprecated-test-plugin");
Similar to the sandboxed plugins, I think this is another test we should try to
write without using the deprecated plugin. We can just use a message listener on
the element to listen for the 'loaded' message from the non-deprecated plugin.
Then we won't need onNew either.

https://codereview.chromium.org/1821103002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/plugins/embed-attributes-setting.html
(right):

https://codereview.chromium.org/1821103002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/plugins/embed-attributes-setting.html:51:
shouldBe("typeof embed.testPassTestObject", "function");
Similarly, can we use a message listener + the non-deprecated plugin to check
successful load?

https://codereview.chromium.org/1821103002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/plugins/no-mime-with-valid-extension.html
(right):

https://codereview.chromium.org/1821103002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/plugins/no-mime-with-valid-extension.html:15:
<embed id="plugin" name="plugin" src="resources/test.blinktestplugin"
logInit="1">
Can we register separate extensions for the non-deprecated and the deprecated
plugin, and use the non-deprecated one here?

[piman, 2016-03-23 05:30:25]

https://codereview.chromium.org/1821103002/diff/20001/content/common/pepper_p...
File content/common/pepper_plugin_list.cc (right):

https://codereview.chromium.org/1821103002/diff/20001/content/common/pepper_p...
content/common/pepper_plugin_list.cc:58: // mime-type-data = <mime-type> + *(
LWS + "#" + LWS + <extension> )
On 2016/03/22 18:03:05, dcheng wrote:
> Nit: I think this should be *1, since there can only be one extension
> associated?

[] actually. *1 is 1 or more. I intended to support that (for .png), but turns
out I didn't need to.

https://codereview.chromium.org/1821103002/diff/20001/ppapi/tests/blink_depre...
File ppapi/tests/blink_deprecated_test_plugin.cc (right):

https://codereview.chromium.org/1821103002/diff/20001/ppapi/tests/blink_depre...
ppapi/tests/blink_deprecated_test_plugin.cc:131: "normalize",
On 2016/03/22 18:03:05, dcheng wrote:
> Can we add add documentation about the various attributes/methods/properties
> exposed by the test plugin to the file-level comment?

Done.

https://codereview.chromium.org/1821103002/diff/20001/ppapi/tests/blink_depre...
ppapi/tests/blink_deprecated_test_plugin.cc:318: }
On 2016/03/22 18:03:05, dcheng wrote:
> Nit: newline.

Done.

https://codereview.chromium.org/1821103002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/permissionclient/plugin-permission.html
(right):

https://codereview.chromium.org/1821103002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/permissionclient/plugin-permission.html:37:
plugin.setAttribute("type", "application/x-blink-deprecated-test-plugin");
On 2016/03/22 18:03:05, dcheng wrote:
> Similar to the sandboxed plugins, I think this is another test we should try
to
> write without using the deprecated plugin. We can just use a message listener
on
> the element to listen for the 'loaded' message from the non-deprecated plugin.
> Then we won't need onNew either.

As discussed, we can use the "regular" plugin and test postMessage itself (for
both positive and negative testing) rather than relying on posted message. It
makes this test simpler and faster.

https://codereview.chromium.org/1821103002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/plugins/embed-attributes-setting.html
(right):

https://codereview.chromium.org/1821103002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/plugins/embed-attributes-setting.html:51:
shouldBe("typeof embed.testPassTestObject", "function");
On 2016/03/22 18:03:05, dcheng wrote:
> Similarly, can we use a message listener + the non-deprecated plugin to check
> successful load?

used "regular" plugin and postMessage here too.

https://codereview.chromium.org/1821103002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/plugins/no-mime-with-valid-extension.html
(right):

https://codereview.chromium.org/1821103002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/plugins/no-mime-with-valid-extension.html:15:
<embed id="plugin" name="plugin" src="resources/test.blinktestplugin"
logInit="1">
On 2016/03/22 18:03:05, dcheng wrote:
> Can we register separate extensions for the non-deprecated and the deprecated
> plugin, and use the non-deprecated one here?

Done.

[piman, 2016-03-23 05:30:34]

The CQ bit was checked by piman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-23 05:30:48]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1821103002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1821103002/60001

[dcheng, 2016-03-23 05:37:38]

lgtm

[commit-bot: I haz the power, 2016-03-23 07:34:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-23 07:34:58]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[piman, 2016-03-23 20:15:24]

The CQ bit was checked by piman@chromium.org

[piman, 2016-03-23 20:15:25]

The patchset sent to the CQ was uploaded after l-g-t-m from dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/1821103002/#ps80001
(title: "rebase; fix expectations for plugin-initiate-popup-window-expected")

[commit-bot: I haz the power, 2016-03-23 20:15:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1821103002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1821103002/80001

[commit-bot: I haz the power, 2016-03-23 21:23:26]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-03-23 21:24:57]

Description was changed from

==========
Migrate a bunch of LayoutTests from NPAPI to PPAPI

- Add a way to specify extensions handled by plugins. Flash needs it, so we need
to test the feature
- Fix PluginObject::EnumerateNamedProperties to correctly raise an exception
when the object is deleted
- Remove a couple of tests that exercise NPAPI features that don't exist / we
don't need on PPAPI (NPN_ReloadPlugins, using plugin to handle images)
- Add some extra API to blink_deprecated_test_plugin and port tests over.

BUG=318978, 474535
==========

to

==========
Migrate a bunch of LayoutTests from NPAPI to PPAPI

- Add a way to specify extensions handled by plugins. Flash needs it, so we need
to test the feature
- Fix PluginObject::EnumerateNamedProperties to correctly raise an exception
when the object is deleted
- Remove a couple of tests that exercise NPAPI features that don't exist / we
don't need on PPAPI (NPN_ReloadPlugins, using plugin to handle images)
- Add some extra API to blink_deprecated_test_plugin and port tests over.

BUG=318978, 474535

Committed: https://crrev.com/a7f9ca2dc86876b60a1080c5531336a8bea88b6f
Cr-Commit-Position: refs/heads/master@{#382929}
==========

[commit-bot: I haz the power, 2016-03-23 21:24:58]

Patchset 4 (id:??) landed as
https://crrev.com/a7f9ca2dc86876b60a1080c5531336a8bea88b6f
Cr-Commit-Position: refs/heads/master@{#382929}