third_party/WebKit/LayoutTests/plugins/plugin-initiate-popup-window.html - Issue 1821103002: Migrate a bunch of LayoutTests from NPAPI to PPAPI

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/plugins/plugin-initiate-popup-window.html

Issue 1821103002: Migrate a bunch of LayoutTests from NPAPI to PPAPI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fix_open-and-close-window-with-plugin

Patch Set: rebase; fix expectations for plugin-initiate-popup-window-expected Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/plugins/plugin-destroyed-enumerate-expected.txt ('k') | third_party/WebKit/LayoutTests/plugins/plugin-initiate-popup-window-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/plugins/plugin-initiate-popup-window.html

diff --git a/third_party/WebKit/LayoutTests/plugins/plugin-initiate-popup-window.html b/third_party/WebKit/LayoutTests/plugins/plugin-initiate-popup-window.html

index 080120a2db4afb5b1dc8a010ef5252548ba10e90..7958ad5f809b987d59b9e13885e0511b3ee56684 100644

--- a/third_party/WebKit/LayoutTests/plugins/plugin-initiate-popup-window.html

+++ b/third_party/WebKit/LayoutTests/plugins/plugin-initiate-popup-window.html

@@ -65,8 +65,8 @@ function end_test() {

</script>

</head>

-<embed type="application/x-webkit-test-netscape" width=100 height=40 evaluatescript="mouse::popup_by_mousedown()" windowedplugin="false"></embed>

-<embed type="application/x-webkit-test-netscape" width=100 height=40 evaluatescript="key::popup_by_keydown()" windowedplugin="false"></embed>

+<embed type="application/x-blink-deprecated-test-plugin" width=100 height=40 mousedownscript="popup_by_mousedown()" windowedplugin="false"></embed>

+<embed type="application/x-blink-deprecated-test-plugin" width=100 height=40 keydownscript="popup_by_keydown()" windowedplugin="false"></embed>

Specify a script and a mouse/keyboard event to the plugin. The specified script will be evaluated in the browser when the specified event is received by the plugin. The test is for bug https://bugs.webkit.org/show_bug.cgi?id=41292.

Opening window by mouse down is FAILED

Opening window by key down is FAILED