Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4301)

Unified Diff: chrome/browser/google_apis/base_requests.h

Issue 18211008: Add resource ID based download requests in {GDataWapi/Drive} requests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Reorder parameters. Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/drive/gdata_wapi_service.cc ('k') | chrome/browser/google_apis/base_requests.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/google_apis/base_requests.h
diff --git a/chrome/browser/google_apis/base_requests.h b/chrome/browser/google_apis/base_requests.h
index 7236b8a441a98a2ac0ce6404aee51b03a72c9557..47c98b16b43fad068c5d380a3168c2c4f8719397 100644
--- a/chrome/browser/google_apis/base_requests.h
+++ b/chrome/browser/google_apis/base_requests.h
@@ -438,8 +438,8 @@ typedef base::Callback<void(GDataErrorCode error,
const base::FilePath& temp_file)>
DownloadActionCallback;
-// This class performs the request for downloading of a given document/file.
-class DownloadFileRequest : public UrlFetchRequestBase {
+// This is a base class for performing the request for downloading a file.
+class DownloadFileRequestBase : public UrlFetchRequestBase {
public:
// download_action_callback:
// This callback is called when the download is complete. Must not be null.
@@ -458,13 +458,14 @@ class DownloadFileRequest : public UrlFetchRequestBase {
// output_file_path:
// Specifies the file path to save the downloaded file.
//
- DownloadFileRequest(RequestSender* sender,
- const DownloadActionCallback& download_action_callback,
- const GetContentCallback& get_content_callback,
- const ProgressCallback& progress_callback,
- const GURL& download_url,
- const base::FilePath& output_file_path);
- virtual ~DownloadFileRequest();
+ DownloadFileRequestBase(
+ RequestSender* sender,
+ const DownloadActionCallback& download_action_callback,
+ const GetContentCallback& get_content_callback,
+ const ProgressCallback& progress_callback,
+ const GURL& download_url,
+ const base::FilePath& output_file_path);
+ virtual ~DownloadFileRequestBase();
protected:
// UrlFetchRequestBase overrides.
@@ -488,7 +489,7 @@ class DownloadFileRequest : public UrlFetchRequestBase {
const GURL download_url_;
const base::FilePath output_file_path_;
- DISALLOW_COPY_AND_ASSIGN(DownloadFileRequest);
+ DISALLOW_COPY_AND_ASSIGN(DownloadFileRequestBase);
};
} // namespace google_apis
« no previous file with comments | « chrome/browser/drive/gdata_wapi_service.cc ('k') | chrome/browser/google_apis/base_requests.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698