Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1172)

Unified Diff: chrome/browser/drive/gdata_wapi_service.cc

Issue 18211008: Add resource ID based download requests in {GDataWapi/Drive} requests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Reorder parameters. Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/drive/drive_api_service.cc ('k') | chrome/browser/google_apis/base_requests.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/drive/gdata_wapi_service.cc
diff --git a/chrome/browser/drive/gdata_wapi_service.cc b/chrome/browser/drive/gdata_wapi_service.cc
index 7198edb5e851377dcaefaa14abe93e229d97b677..a83955496b93d325154ce64104848125b9c17c68 100644
--- a/chrome/browser/drive/gdata_wapi_service.cc
+++ b/chrome/browser/drive/gdata_wapi_service.cc
@@ -32,7 +32,7 @@ using google_apis::CopyHostedDocumentRequest;
using google_apis::CreateDirectoryRequest;
using google_apis::DeleteResourceRequest;
using google_apis::DownloadActionCallback;
-using google_apis::DownloadFileRequest;
+using google_apis::DownloadFileRequestBase;
using google_apis::EntryActionCallback;
using google_apis::GDataErrorCode;
using google_apis::GDATA_PARSE_ERROR;
@@ -340,13 +340,14 @@ CancelCallback GDataWapiService::DownloadFile(
DCHECK(!download_action_callback.is_null());
// get_content_callback and progress_callback may be null.
+ // TODO(kinaba): crbug.com/254025: use resource_id based download request.
return sender_->StartRequestWithRetry(
- new DownloadFileRequest(sender_.get(),
- download_action_callback,
- get_content_callback,
- progress_callback,
- download_url,
- local_cache_path));
+ new DownloadFileRequestBase(sender_.get(),
+ download_action_callback,
+ get_content_callback,
+ progress_callback,
+ download_url,
+ local_cache_path));
}
CancelCallback GDataWapiService::DeleteResource(
« no previous file with comments | « chrome/browser/drive/drive_api_service.cc ('k') | chrome/browser/google_apis/base_requests.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698