Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 1821043005: Add URL validation to navigations initiated via RenderFrameProxyHosts. (Closed)

Created:
4 years, 9 months ago by alexmos
Modified:
4 years, 9 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

Add URL validation to navigations initiated via RenderFrameProxyHosts. When we changed RenderFrameProxyHost::OnOpenURL to use the transfer logic in r377832, we lost FilterURL validation provided by RenderFrameHostImpl::OpenURL. This CL adds that validation to navigations initiated via proxies. BUG=595339 TBR=creis@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Review URL: https://codereview.chromium.org/1812723002 Cr-Commit-Position: refs/heads/master@{#381788} (cherry picked from commit 5b50b674d36956c84a499b4f93e65a874de28713) Committed: https://chromium.googlesource.com/chromium/src/+/52505b8cec39e5dcbf8e04f6dbe7ea1b92890e49

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -1 line) Patch
M content/browser/frame_host/render_frame_proxy_host.cc View 2 chunks +4 lines, -1 line 0 comments Download
M content/browser/site_per_process_browsertest.cc View 2 chunks +37 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
alexmos
4 years, 9 months ago (2016-03-22 23:51:30 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
52505b8cec39e5dcbf8e04f6dbe7ea1b92890e49.

Powered by Google App Engine
This is Rietveld 408576698