Add URL validation to navigations initiated via RenderFrameProxyHosts.

Add URL validation to navigations initiated via RenderFrameProxyHosts.

When we changed RenderFrameProxyHost::OnOpenURL to use the transfer
logic in r377832, we lost FilterURL validation provided by
RenderFrameHostImpl::OpenURL.  This CL adds that validation to
navigations initiated via proxies.

BUG=595339
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/5b50b674d36956c84a499b4f93e65a874de28713
Cr-Commit-Position: refs/heads/master@{#381788}

[alexmos, 2016-03-17 00:15:09]

Description was changed from

==========
Add URL validation to navigations initiated via RenderFrameProxyHosts.

When we changed RenderFrameProxyHost::OnOpenURL to use the transfer
logic in r377832, we lost FilterURL validation provided by
RenderFrameHostImpl::OpenURL.  This CL adds that validation to
navigations initiated via proxies.

BUG=595339
==========

to

==========
Add URL validation to navigations initiated via RenderFrameProxyHosts.

When we changed RenderFrameProxyHost::OnOpenURL to use the transfer
logic in r377832, we lost FilterURL validation provided by
RenderFrameHostImpl::OpenURL.  This CL adds that validation to
navigations initiated via proxies.

BUG=595339
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[alexmos, 2016-03-17 00:21:12]

alexmos@chromium.org changed reviewers:
+ creis@chromium.org

[alexmos, 2016-03-17 00:21:12]

Charlie, can you please take a look?  I took a look around RFPH, and this seemed
to be the only place that needed this validation.

[Charlie Reis, 2016-03-17 17:22:28]

Yes, thanks for tracking that down!  LGTM with nit.

https://codereview.chromium.org/1812723002/diff/20001/content/browser/frame_h...
File content/browser/frame_host/render_frame_proxy_host.cc (right):

https://codereview.chromium.org/1812723002/diff/20001/content/browser/frame_h...
content/browser/frame_host/render_frame_proxy_host.cc:262:
GetProcess()->FilterURL(false, &validated_url);
nit: We usually try to put this as the first thing in the method, so that other
uses of params.url don't creep in above it.

[alexmos, 2016-03-17 17:30:48]

Thanks!

https://codereview.chromium.org/1812723002/diff/20001/content/browser/frame_h...
File content/browser/frame_host/render_frame_proxy_host.cc (right):

https://codereview.chromium.org/1812723002/diff/20001/content/browser/frame_h...
content/browser/frame_host/render_frame_proxy_host.cc:262:
GetProcess()->FilterURL(false, &validated_url);
On 2016/03/17 17:22:27, Charlie Reis wrote:
> nit: We usually try to put this as the first thing in the method, so that
other
> uses of params.url don't creep in above it.

Done.

[alexmos, 2016-03-17 17:30:55]

The CQ bit was checked by alexmos@chromium.org

[alexmos, 2016-03-17 17:30:56]

The patchset sent to the CQ was uploaded after l-g-t-m from creis@chromium.org
Link to the patchset: https://codereview.chromium.org/1812723002/#ps40001
(title: "Charlie's nit")

[commit-bot: I haz the power, 2016-03-17 17:31:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1812723002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1812723002/40001

[commit-bot: I haz the power, 2016-03-17 19:25:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-17 19:25:49]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[alexmos, 2016-03-17 19:53:47]

The CQ bit was checked by alexmos@chromium.org

[commit-bot: I haz the power, 2016-03-17 19:54:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1812723002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1812723002/40001

[commit-bot: I haz the power, 2016-03-17 20:38:14]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-17 20:39:38]

Description was changed from

==========
Add URL validation to navigations initiated via RenderFrameProxyHosts.

When we changed RenderFrameProxyHost::OnOpenURL to use the transfer
logic in r377832, we lost FilterURL validation provided by
RenderFrameHostImpl::OpenURL.  This CL adds that validation to
navigations initiated via proxies.

BUG=595339
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Add URL validation to navigations initiated via RenderFrameProxyHosts.

When we changed RenderFrameProxyHost::OnOpenURL to use the transfer
logic in r377832, we lost FilterURL validation provided by
RenderFrameHostImpl::OpenURL.  This CL adds that validation to
navigations initiated via proxies.

BUG=595339
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/5b50b674d36956c84a499b4f93e65a874de28713
Cr-Commit-Position: refs/heads/master@{#381788}
==========

[commit-bot: I haz the power, 2016-03-17 20:39:39]

Patchset 3 (id:??) landed as
https://crrev.com/5b50b674d36956c84a499b4f93e65a874de28713
Cr-Commit-Position: refs/heads/master@{#381788}