Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1821043003: Remove FX_WORD in favor of uint16_t. (Closed)

Created:
4 years, 9 months ago by Tom Sepez
Modified:
4 years, 9 months ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove FX_WORD in favor of uint16_t. It isn't buying us anthing, and it looks strange in a struct when other uint types are already present. R=dsinclair@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/62a70f90c49cf7714c960186eb063ad55333e6f3

Patch Set 1 #

Total comments: 12

Patch Set 2 : Use stdint.h directly, bitfield minefield. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+893 lines, -892 lines) Patch
M core/fpdfapi/fpdf_cmaps/CNS1/Adobe-CNS1-UCS2_5.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_cmaps/CNS1/B5pc-H_0.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_cmaps/CNS1/B5pc-V_0.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_cmaps/CNS1/CNS-EUC-H_0.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M core/fpdfapi/fpdf_cmaps/CNS1/CNS-EUC-V_0.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M core/fpdfapi/fpdf_cmaps/CNS1/ETen-B5-H_0.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_cmaps/CNS1/ETen-B5-V_0.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_cmaps/CNS1/ETenms-B5-H_0.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_cmaps/CNS1/ETenms-B5-V_0.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_cmaps/CNS1/HKscs-B5-H_5.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_cmaps/CNS1/HKscs-B5-V_5.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_cmaps/CNS1/UniCNS-UCS2-H_3.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_cmaps/CNS1/UniCNS-UCS2-V_3.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_cmaps/CNS1/UniCNS-UTF16-H_0.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_cmaps/CNS1/cmaps_cns1.h View 1 1 chunk +17 lines, -17 lines 0 comments Download
M core/fpdfapi/fpdf_cmaps/GB1/Adobe-GB1-UCS2_5.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_cmaps/GB1/GB-EUC-H_0.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_cmaps/GB1/GB-EUC-V_0.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_cmaps/GB1/GBK-EUC-H_2.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_cmaps/GB1/GBK-EUC-V_2.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_cmaps/GB1/GBK2K-H_5.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M core/fpdfapi/fpdf_cmaps/GB1/GBK2K-V_5.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_cmaps/GB1/GBKp-EUC-H_2.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_cmaps/GB1/GBKp-EUC-V_2.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_cmaps/GB1/GBpc-EUC-H_0.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_cmaps/GB1/GBpc-EUC-V_0.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_cmaps/GB1/UniGB-UCS2-H_4.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_cmaps/GB1/UniGB-UCS2-V_4.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_cmaps/GB1/cmaps_gb1.h View 1 1 chunk +15 lines, -15 lines 0 comments Download
M core/fpdfapi/fpdf_cmaps/Japan1/83pv-RKSJ-H_1.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_cmaps/Japan1/90ms-RKSJ-H_2.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_cmaps/Japan1/90ms-RKSJ-V_2.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_cmaps/Japan1/90msp-RKSJ-H_2.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_cmaps/Japan1/90msp-RKSJ-V_2.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_cmaps/Japan1/90pv-RKSJ-H_1.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_cmaps/Japan1/Add-RKSJ-H_1.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_cmaps/Japan1/Add-RKSJ-V_1.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_cmaps/Japan1/Adobe-Japan1-UCS2_4.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_cmaps/Japan1/EUC-H_1.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_cmaps/Japan1/EUC-V_1.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_cmaps/Japan1/Ext-RKSJ-H_2.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_cmaps/Japan1/Ext-RKSJ-V_2.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_cmaps/Japan1/H_1.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_cmaps/Japan1/UniJIS-UCS2-HW-H_4.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_cmaps/Japan1/UniJIS-UCS2-HW-V_4.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_cmaps/Japan1/UniJIS-UCS2-H_4.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_cmaps/Japan1/UniJIS-UCS2-V_4.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_cmaps/Japan1/V_1.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_cmaps/Japan1/cmaps_japan1.h View 1 1 chunk +23 lines, -23 lines 0 comments Download
M core/fpdfapi/fpdf_cmaps/Korea1/Adobe-Korea1-UCS2_2.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_cmaps/Korea1/KSC-EUC-H_0.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_cmaps/Korea1/KSC-EUC-V_0.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_cmaps/Korea1/KSCms-UHC-HW-H_1.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_cmaps/Korea1/KSCms-UHC-HW-V_1.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_cmaps/Korea1/KSCms-UHC-H_1.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_cmaps/Korea1/KSCms-UHC-V_1.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_cmaps/Korea1/KSCpc-EUC-H_0.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_cmaps/Korea1/UniKS-UCS2-H_1.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_cmaps/Korea1/UniKS-UCS2-V_1.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_cmaps/Korea1/UniKS-UTF16-H_0.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_cmaps/Korea1/cmaps_korea1.h View 1 1 chunk +12 lines, -12 lines 0 comments Download
M core/fpdfapi/fpdf_cmaps/cmap_int.h View 1 2 chunks +5 lines, -5 lines 0 comments Download
M core/fpdfapi/fpdf_cmaps/fpdf_cmaps.cpp View 10 chunks +28 lines, -28 lines 0 comments Download
M core/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M core/fpdfapi/fpdf_font/font_int.h View 5 chunks +7 lines, -7 lines 0 comments Download
M core/fpdfapi/fpdf_font/fpdf_font.cpp View 9 chunks +9 lines, -9 lines 0 comments Download
M core/fpdfapi/fpdf_font/fpdf_font_charset.cpp View 11 chunks +12 lines, -12 lines 0 comments Download
M core/fpdfapi/fpdf_font/fpdf_font_cid.cpp View 22 chunks +32 lines, -31 lines 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_textobject.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_parser_unittest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_parser/fpdf_parser_decode.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M core/fpdfapi/fpdf_parser/include/fpdf_parser_decode.h View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_render/fpdf_render_text.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfdoc/doc_ap.cpp View 6 chunks +7 lines, -7 lines 0 comments Download
M core/fpdfdoc/doc_form.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfdoc/doc_vt.cpp View 10 chunks +14 lines, -14 lines 0 comments Download
M core/fpdfdoc/pdf_vt.h View 8 chunks +13 lines, -13 lines 0 comments Download
M core/fpdftext/fpdf_text_int.h View 2 chunks +2 lines, -2 lines 0 comments Download
M core/fxcodec/codec/fx_codec_flate.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M core/fxcodec/codec/fx_codec_tiff.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M core/fxcodec/jbig2/JBig2_BitStream.h View 1 chunk +1 line, -1 line 0 comments Download
M core/fxcodec/jbig2/JBig2_BitStream.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fxcodec/jbig2/JBig2_Context.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M core/fxcodec/jbig2/JBig2_GrdProc.h View 1 chunk +1 line, -1 line 0 comments Download
M core/fxcodec/jbig2/JBig2_HtrdProc.h View 1 chunk +2 lines, -2 lines 0 comments Download
M core/fxcodec/jbig2/JBig2_Page.h View 1 chunk +1 line, -1 line 0 comments Download
M core/fxcodec/lbmp/fx_bmp.h View 4 chunks +13 lines, -13 lines 0 comments Download
M core/fxcodec/lbmp/fx_bmp.cpp View 5 chunks +6 lines, -6 lines 0 comments Download
M core/fxcodec/lgif/fx_gif.h View 7 chunks +26 lines, -26 lines 0 comments Download
M core/fxcodec/lgif/fx_gif.cpp View 11 chunks +13 lines, -13 lines 0 comments Download
M core/fxcrt/fx_arabic.cpp View 3 chunks +7 lines, -7 lines 0 comments Download
M core/fxcrt/fx_basic_wstring.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M core/fxcrt/fx_unicode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fxge/apple/apple_int.h View 1 chunk +1 line, -1 line 0 comments Download
M core/fxge/apple/fx_apple_platform.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fxge/apple/fx_quartz_device.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M core/fxge/ge/fx_ge_fontmap.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M core/fxge/win32/fx_win32_print.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/include/fpdfapi/fpdf_resource.h View 4 chunks +10 lines, -10 lines 0 comments Download
M core/include/fpdfdoc/fpdf_ap.h View 2 chunks +4 lines, -4 lines 0 comments Download
M core/include/fpdfdoc/fpdf_vt.h View 5 chunks +7 lines, -7 lines 0 comments Download
M core/include/fxcodec/fx_codec.h View 1 chunk +1 line, -1 line 0 comments Download
M core/include/fxcrt/fx_basic.h View 2 chunks +2 lines, -3 lines 0 comments Download
M core/include/fxcrt/fx_ext.h View 1 chunk +2 lines, -2 lines 0 comments Download
M core/include/fxcrt/fx_string.h View 1 chunk +1 line, -1 line 0 comments Download
M core/include/fxcrt/fx_system.h View 2 chunks +2 lines, -3 lines 0 comments Download
M core/include/fxcrt/fx_ucd.h View 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/formfiller/cffl_formfiller.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fpdfppo.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M fpdfsdk/fsdk_baseannot.cpp View 4 chunks +10 lines, -10 lines 0 comments Download
M fpdfsdk/fsdk_baseform.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fxedit/fxet_ap.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/fxedit/fxet_edit.cpp View 13 chunks +13 lines, -13 lines 0 comments Download
M fpdfsdk/fxedit/fxet_list.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/fxedit/fxet_pageobjs.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/fsdk_mgr.h View 1 chunk +3 lines, -3 lines 0 comments Download
M fpdfsdk/include/fx_systemhandler.h View 1 chunk +8 lines, -8 lines 0 comments Download
M fpdfsdk/include/fxedit/fx_edit.h View 7 chunks +10 lines, -10 lines 0 comments Download
M fpdfsdk/include/fxedit/fxet_edit.h View 14 chunks +16 lines, -16 lines 0 comments Download
M fpdfsdk/include/fxedit/fxet_list.h View 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_ComboBox.h View 2 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_Edit.h View 2 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_EditCtrl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_FontMap.h View 2 chunks +5 lines, -5 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_IconList.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_ListBox.h View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_SpecialButton.h View 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_Utils.h View 2 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_Wnd.h View 1 chunk +3 lines, -3 lines 0 comments Download
M fpdfsdk/javascript/Document.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/javascript/JS_GlobalData.cpp View 7 chunks +21 lines, -21 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_ComboBox.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_Edit.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_EditCtrl.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_FontMap.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_IconList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/pdfwindow/PWL_ListBox.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_SpecialButton.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_Utils.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/pdfwindow/PWL_Wnd.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + xfa/fde/css/#fde_cssstyleselector.h# View 1 4 chunks +20 lines, -20 lines 0 comments Download
M xfa/fde/css/fde_css.h View 2 chunks +5 lines, -5 lines 0 comments Download
M xfa/fde/css/fde_cssdatatable.h View 1 chunk +4 lines, -4 lines 0 comments Download
M xfa/fde/css/fde_cssdatatable.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M xfa/fde/css/fde_cssstyleselector.h View 1 4 chunks +20 lines, -21 lines 0 comments Download
M xfa/fde/css/fde_cssstyleselector.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fde/css/fde_cssstylesheet.h View 2 chunks +5 lines, -5 lines 0 comments Download
M xfa/fde/css/fde_cssstylesheet.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M xfa/fde/css/fde_csssyntax.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fde/xml/fde_xml_imp.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M xfa/fee/fx_wordbreak/fx_wordbreak_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fee/fx_wordbreak/fx_wordbreak_impl.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fee/fx_wordbreak/fx_wordbreakdata.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fgas/crt/fgas_codepage.h View 1 chunk +8 lines, -8 lines 0 comments Download
M xfa/fgas/crt/fgas_codepage.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M xfa/fgas/crt/fgas_encode.cpp View 4 chunks +14 lines, -14 lines 0 comments Download
M xfa/fgas/crt/fgas_stream.h View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fgas/crt/fgas_stream.cpp View 5 chunks +10 lines, -10 lines 0 comments Download
M xfa/fgas/crt/fgas_utils.h View 4 chunks +4 lines, -4 lines 0 comments Download
M xfa/fgas/font/fgas_font.h View 10 chunks +15 lines, -15 lines 0 comments Download
M xfa/fgas/font/fgas_fontutils.h View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fgas/font/fgas_fontutils.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/fgas/font/fgas_gefont.h View 2 chunks +3 lines, -3 lines 0 comments Download
M xfa/fgas/font/fgas_gefont.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M xfa/fgas/font/fgas_stdfontmgr.h View 8 chunks +13 lines, -13 lines 0 comments Download
M xfa/fgas/font/fgas_stdfontmgr.cpp View 19 chunks +31 lines, -30 lines 0 comments Download
M xfa/fgas/layout/fgas_linebreak.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M xfa/fgas/layout/fgas_rtfbreak.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fgas/layout/fgas_textbreak.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M xfa/fgas/localization/fgas_datetime.h View 5 chunks +9 lines, -9 lines 0 comments Download
M xfa/fgas/localization/fgas_datetime.cpp View 10 chunks +18 lines, -18 lines 0 comments Download
M xfa/fgas/localization/fgas_locale.h View 2 chunks +4 lines, -4 lines 0 comments Download
M xfa/fgas/localization/fgas_locale.cpp View 16 chunks +31 lines, -31 lines 0 comments Download
M xfa/fgas/localization/fgas_localeimp.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fgas/localization/fgas_localemgr.h View 1 chunk +4 lines, -4 lines 0 comments Download
M xfa/fgas/localization/fgas_localemgr.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M xfa/fwl/basewidget/fwl_scrollbarimp.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/theme/widgettp.cpp View 3 chunks +7 lines, -7 lines 0 comments Download
M xfa/fxbarcode/datamatrix/BC_ErrorCorrection.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M xfa/fxbarcode/pdf417/BC_PDF417DecodedBitStreamParser.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M xfa/fxfa/app/xfa_ffwidget.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/app/xfa_fontmgr.h View 3 chunks +5 lines, -5 lines 0 comments Download
M xfa/fxfa/app/xfa_fontmgr.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M xfa/fxfa/parser/xfa_basic_data.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_basic_data.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_basic_imp.h View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fxfa/parser/xfa_basic_imp.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M xfa/fxfa/parser/xfa_localemgr.h View 2 chunks +4 lines, -4 lines 0 comments Download
M xfa/fxfa/parser/xfa_localemgr.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M xfa/fxfa/parser/xfa_localevalue.cpp View 2 chunks +13 lines, -13 lines 0 comments Download
M xfa/fxfa/parser/xfa_object.h View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/fxfa/parser/xfa_object_imp.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_parser_imp.h View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fxfa/parser/xfa_parser_imp.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/include/fwl/theme/widgettp.h View 2 chunks +3 lines, -3 lines 0 comments Download
M xfa/include/fxfa/fxfa.h View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/include/fxfa/fxfa_basic.h View 3 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Tom Sepez
On 2016/03/21 21:14:55, Tom Sepez wrote: > mailto:tsepez@chromium.org changed reviewers: > + mailto:dsinclair@chromium.org Dan, for ...
4 years, 9 months ago (2016-03-21 21:16:31 UTC) #3
dsinclair
lgtm ++ https://codereview.chromium.org/1821043003/diff/1/core/fpdfapi/fpdf_cmaps/CNS1/cmaps_cns1.h File core/fpdfapi/fpdf_cmaps/CNS1/cmaps_cns1.h (right): https://codereview.chromium.org/1821043003/diff/1/core/fpdfapi/fpdf_cmaps/CNS1/cmaps_cns1.h#newcode10 core/fpdfapi/fpdf_cmaps/CNS1/cmaps_cns1.h:10: #include "core/include/fxcrt/fx_system.h" // For uint16_t. nit: remove ...
4 years, 9 months ago (2016-03-21 21:33:12 UTC) #4
Tom Sepez
https://codereview.chromium.org/1821043003/diff/1/core/fpdfapi/fpdf_cmaps/CNS1/cmaps_cns1.h File core/fpdfapi/fpdf_cmaps/CNS1/cmaps_cns1.h (right): https://codereview.chromium.org/1821043003/diff/1/core/fpdfapi/fpdf_cmaps/CNS1/cmaps_cns1.h#newcode10 core/fpdfapi/fpdf_cmaps/CNS1/cmaps_cns1.h:10: #include "core/include/fxcrt/fx_system.h" // For uint16_t. On 2016/03/21 21:33:12, dsinclair ...
4 years, 9 months ago (2016-03-21 21:59:48 UTC) #5
Tom Sepez
4 years, 9 months ago (2016-03-21 22:00:27 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
62a70f90c49cf7714c960186eb063ad55333e6f3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698