core/fpdfapi/fpdf_parser/cpdf_parser_unittest.cpp - Issue 1821043003: Remove FX_WORD in favor of uint16_t.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/fpdf_parser/cpdf_parser_unittest.cpp

Issue 1821043003: Remove FX_WORD in favor of uint16_t. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Use stdint.h directly, bitfield minefield. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/fpdf_parser/cpdf_parser_unittest.cpp

diff --git a/core/fpdfapi/fpdf_parser/cpdf_parser_unittest.cpp b/core/fpdfapi/fpdf_parser/cpdf_parser_unittest.cpp

index b343618f284c2357c931e74f5d77d0e307ff8269..dc4d757120023b4161bae7d290787306fd198e5b 100644

--- a/core/fpdfapi/fpdf_parser/cpdf_parser_unittest.cpp

+++ b/core/fpdfapi/fpdf_parser/cpdf_parser_unittest.cpp

@@ -82,7 +82,7 @@ TEST(cpdf_parser, RebuildCrossRefCorrectly) {

ASSERT_TRUE(parser.RebuildCrossRef());

const FX_FILESIZE offsets[] = {0, 15, 61, 154, 296, 374, 450};

- const FX_WORD versions[] = {0, 0, 2, 4, 6, 8, 0};

+ const uint16_t versions[] = {0, 0, 2, 4, 6, 8, 0};

for (size_t i = 0; i < FX_ArraySize(offsets); ++i)

EXPECT_EQ(offsets[i], parser.m_ObjectInfo[i].pos);

for (size_t i = 0; i < FX_ArraySize(versions); ++i)