Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(883)

Issue 1820903002: [es6] Ship new ES6 instanceof operator semantics. (Closed)

Created:
4 years, 9 months ago by Michael Starzinger
Modified:
4 years, 9 months ago
Reviewers:
Michael Hablich
CC:
v8-reviews_googlegroups.com, rossberg, adamk
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_instanceof-stub-param
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] Ship new ES6 instanceof operator semantics. R=hablich@chromium.org BUG=v8:4447 LOG=n Committed: https://crrev.com/5836807ea89b96ecfb4bbd8febf0d67bb8dae9ed Cr-Commit-Position: refs/heads/master@{#34984}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/flag-definitions.h View 2 chunks +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (2 generated)
Michael Starzinger
Michael: This can be landed at the earliest tomorrow from my end. Please advise on ...
4 years, 9 months ago (2016-03-21 15:19:58 UTC) #1
Michael Hablich
On 2016/03/21 15:19:58, Michael Starzinger wrote: > Michael: This can be landed at the earliest ...
4 years, 9 months ago (2016-03-22 11:36:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1820903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1820903002/1
4 years, 9 months ago (2016-03-22 11:38:12 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-22 11:40:34 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5836807ea89b96ecfb4bbd8febf0d67bb8dae9ed Cr-Commit-Position: refs/heads/master@{#34984}
4 years, 9 months ago (2016-03-22 11:42:15 UTC) #7
Michael Starzinger
4 years, 9 months ago (2016-03-22 16:04:05 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1823813003/ by mstarzinger@chromium.org.

The reason for reverting is: Breaks two layout tests when rolling into Chromium.
Tests needs investigation and most likely a rebaseline. The following are the
tests that fail:

-
imported/web-platform-tests/html/semantics/text-level-semantics/the-time-element/001.html
- fast/dom/Window/window-postmessage-clone-deep-array.html

https://storage.googleapis.com/chromium-layout-test-archives/V8-Blink_Linux_6....

Powered by Google App Engine
This is Rietveld 408576698