Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 1819813002: [es6] Faster implementation of OrdinaryHasInstance. (Closed)

Created:
4 years, 9 months ago by Michael Starzinger
Modified:
4 years, 9 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] Faster implementation of OrdinaryHasInstance. Now implemented as a builtin that delegates to the InstanceOfStub. That stub was parameterized to fallback to either Runtime_InstanceOf or to Runtime_OrdinaryHasInstance depending on the --harmony-instanceof flag. Once the feature stabilizes and the flag is no longer needed, we can get rid of this parameterization again. R=bmeurer@chromium.org BUG=v8:4447 LOG=n Committed: https://crrev.com/b6419fa2298de8e292c6bed0bd20de5c96f7da12 Cr-Commit-Position: refs/heads/master@{#34959}

Patch Set 1 : Imported patch from issue 1815203002 at patchset 1 (http://crrev.com/1815203002#ps1) #

Patch Set 2 : Flip flag for testing. #

Patch Set 3 : Address my own comments. #

Total comments: 1

Patch Set 4 : Architecture ports. #

Patch Set 5 : Revert flag-flip again. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+200 lines, -49 lines) Patch
M src/arm/builtins-arm.cc View 1 2 3 1 chunk +21 lines, -0 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M src/arm64/builtins-arm64.cc View 1 2 3 1 chunk +23 lines, -0 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M src/builtins.h View 1 2 3 chunks +2 lines, -1 line 0 comments Download
M src/builtins.cc View 1 chunk +0 lines, -40 lines 0 comments Download
M src/code-stubs.h View 1 2 1 chunk +10 lines, -1 line 0 comments Download
M src/ia32/builtins-ia32.cc View 1 2 3 2 chunks +22 lines, -1 line 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/mips/builtins-mips.cc View 1 2 3 1 chunk +21 lines, -0 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M src/mips64/builtins-mips64.cc View 1 2 3 1 chunk +21 lines, -0 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M src/runtime/runtime.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime-object.cc View 1 2 2 chunks +45 lines, -0 lines 0 comments Download
M src/x64/builtins-x64.cc View 1 2 3 1 chunk +22 lines, -0 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (8 generated)
Michael Starzinger
Took this CL over from Michael Stanton since he is gone for the week. Note ...
4 years, 9 months ago (2016-03-21 12:47:00 UTC) #5
Michael Starzinger
https://codereview.chromium.org/1819813002/diff/40001/src/flag-definitions.h File src/flag-definitions.h (right): https://codereview.chromium.org/1819813002/diff/40001/src/flag-definitions.h#newcode222 src/flag-definitions.h:222: V(harmony_instanceof, "harmony instanceof support") \ Note that the flag-flip ...
4 years, 9 months ago (2016-03-21 12:48:46 UTC) #6
Michael Starzinger
Ports are done. This is ready for final review.
4 years, 9 months ago (2016-03-21 14:54:43 UTC) #7
Benedikt Meurer
lgtm
4 years, 9 months ago (2016-03-21 17:58:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1819813002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1819813002/80001
4 years, 9 months ago (2016-03-21 18:02:28 UTC) #11
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 9 months ago (2016-03-21 18:04:34 UTC) #13
commit-bot: I haz the power
4 years, 9 months ago (2016-03-21 18:06:00 UTC) #15
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/b6419fa2298de8e292c6bed0bd20de5c96f7da12
Cr-Commit-Position: refs/heads/master@{#34959}

Powered by Google App Engine
This is Rietveld 408576698