Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1586)

Unified Diff: ct/go/ctfe/chromium_perf/chromium_perf.go

Issue 1820863002: Update callers of httputils.ReportError to specify message (Closed) Base URL: https://skia.googlesource.com/buildbot@master
Patch Set: Remove taskID Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ct/go/ctfe/chromium_builds/chromium_builds.go ('k') | ct/go/ctfe/task_common/task_common.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ct/go/ctfe/chromium_perf/chromium_perf.go
diff --git a/ct/go/ctfe/chromium_perf/chromium_perf.go b/ct/go/ctfe/chromium_perf/chromium_perf.go
index 043d65f233370d8b9cfb4dff78f73312d3a0adc3..e83ccc5cb316be8a962254a286e16a557f5b1046 100644
--- a/ct/go/ctfe/chromium_perf/chromium_perf.go
+++ b/ct/go/ctfe/chromium_perf/chromium_perf.go
@@ -234,7 +234,7 @@ func getCLHandler(w http.ResponseWriter, r *http.Request) {
w.Header().Set("Content-Type", "application/json")
detail, err := getCLDetail(r.FormValue("cl"))
if err != nil {
- httputils.ReportError(w, r, err, "")
+ httputils.ReportError(w, r, err, "Failed to get CL details")
return
}
if detail.Issue == 0 {
@@ -246,16 +246,16 @@ func getCLHandler(w http.ResponseWriter, r *http.Request) {
}
patch, err := getCLPatch(detail, 0)
if err != nil {
- httputils.ReportError(w, r, err, "")
+ httputils.ReportError(w, r, err, "Failed to get CL patch")
return
}
clData, err := gatherCLData(detail, patch)
if err != nil {
- httputils.ReportError(w, r, err, "")
+ httputils.ReportError(w, r, err, "Failed to get CL data")
return
}
if err = json.NewEncoder(w).Encode(clData); err != nil {
- httputils.ReportError(w, r, err, "")
+ httputils.ReportError(w, r, err, "Failed to encode JSON")
return
}
}
@@ -403,22 +403,22 @@ func addTrybotTaskHandler(w http.ResponseWriter, r *http.Request) {
// Add patch data to the task.
detail, err := getCLDetail(trybotTask.Issue)
if err != nil {
- httputils.ReportError(w, r, err, "")
+ httputils.ReportError(w, r, err, "Failed to get CL details")
return
}
patchsetID, err := strconv.Atoi(trybotTask.PatchsetID)
if err != nil {
- httputils.ReportError(w, r, err, "")
+ httputils.ReportError(w, r, err, "Failed to get Patchset ID")
return
}
patch, err := getCLPatch(detail, patchsetID)
if err != nil {
- httputils.ReportError(w, r, err, "")
+ httputils.ReportError(w, r, err, "Failed to get CL patch")
return
}
clData, err := gatherCLData(detail, patch)
if err != nil {
- httputils.ReportError(w, r, err, "")
+ httputils.ReportError(w, r, err, "Failed to get CL data")
return
}
« no previous file with comments | « ct/go/ctfe/chromium_builds/chromium_builds.go ('k') | ct/go/ctfe/task_common/task_common.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698