Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(802)

Unified Diff: ct/go/ctfe/chromium_builds/chromium_builds.go

Issue 1820863002: Update callers of httputils.ReportError to specify message (Closed) Base URL: https://skia.googlesource.com/buildbot@master
Patch Set: Remove taskID Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ct/go/ctfe/chromium_perf/chromium_perf.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ct/go/ctfe/chromium_builds/chromium_builds.go
diff --git a/ct/go/ctfe/chromium_builds/chromium_builds.go b/ct/go/ctfe/chromium_builds/chromium_builds.go
index 800cce70e7db13db7bda48b6378c7bd92cf8196c..00269c7254e3951b177c4e7266f745aa179e75bb 100644
--- a/ct/go/ctfe/chromium_builds/chromium_builds.go
+++ b/ct/go/ctfe/chromium_builds/chromium_builds.go
@@ -158,14 +158,14 @@ func getRevDataHandler(getLkgr func() (string, error), gitRepoUrl string, w http
w.Header().Set("Content-Type", "application/json")
revString := r.FormValue("rev")
if revString == "" {
- httputils.ReportError(w, r, fmt.Errorf("No revision specified"), "")
+ httputils.ReportError(w, r, nil, "No revision specified")
return
}
if strings.EqualFold(revString, "LKGR") {
lkgr, err := getLkgr()
if err != nil {
- httputils.ReportError(w, r, fmt.Errorf("Unable to retrieve LKGR revision"), "")
+ httputils.ReportError(w, r, nil, "Unable to retrieve LKGR revision")
}
glog.Infof("Retrieved LKGR commit hash: %s", lkgr)
revString = lkgr
@@ -187,7 +187,7 @@ func getRevDataHandler(getLkgr func() (string, error), gitRepoUrl string, w http
return
}
if resp.StatusCode != 200 {
- httputils.ReportError(w, r, fmt.Errorf("Unable to retrieve revision detail"), "")
+ httputils.ReportError(w, r, nil, "Unable to retrieve revision detail")
return
}
// Remove junk in the first line. https://code.google.com/p/gitiles/issues/detail?id=31
« no previous file with comments | « no previous file | ct/go/ctfe/chromium_perf/chromium_perf.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698