Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 1820843002: Turn LoadIndexedInterceptor into a Turbofan stub (Closed)

Created:
4 years, 9 months ago by Toon Verwaest
Modified:
4 years, 9 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Turn LoadIndexedInterceptor into a Turbofan stub BUG= Committed: https://crrev.com/9536c3886bc1537b81fb0f5823b443312d4fcc2c Cr-Commit-Position: refs/heads/master@{#34937}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : Rebase #

Patch Set 4 : rebase again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -211 lines) Patch
M src/arm/code-stubs-arm.cc View 1 2 3 1 chunk +0 lines, -23 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 2 3 1 chunk +0 lines, -20 lines 0 comments Download
M src/code-stubs.h View 1 2 3 4 chunks +12 lines, -15 lines 0 comments Download
M src/code-stubs.cc View 1 2 3 1 chunk +22 lines, -0 lines 0 comments Download
M src/compiler/code-stub-assembler.h View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/code-stub-assembler.cc View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 2 3 1 chunk +0 lines, -28 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 2 3 1 chunk +0 lines, -23 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 2 3 1 chunk +0 lines, -23 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 1 chunk +0 lines, -23 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 2 3 1 chunk +0 lines, -28 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 1 chunk +0 lines, -28 lines 0 comments Download

Messages

Total messages: 20 (10 generated)
Toon Verwaest
ptal
4 years, 9 months ago (2016-03-21 09:29:31 UTC) #2
Benedikt Meurer
LGTM with nits. https://codereview.chromium.org/1820843002/diff/1/src/code-stubs.cc File src/code-stubs.cc (right): https://codereview.chromium.org/1820843002/diff/1/src/code-stubs.cc#newcode2345 src/code-stubs.cc:2345: assembler->BranchIfSmiLessThan(key, assembler->Int32Constant(0), Nit: SmiConstant(0) https://codereview.chromium.org/1820843002/diff/1/src/code-stubs.cc#newcode2358 src/code-stubs.cc:2358: ...
4 years, 9 months ago (2016-03-21 09:36:56 UTC) #3
Toon Verwaest
Added WordIsPositiveSmi as the code stubs used to do.
4 years, 9 months ago (2016-03-21 09:41:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1820843002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1820843002/20001
4 years, 9 months ago (2016-03-21 09:47:51 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/15527) v8_linux64_rel_ng on tryserver.v8 (JOB_FAILED, ...
4 years, 9 months ago (2016-03-21 09:49:03 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1820843002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1820843002/40001
4 years, 9 months ago (2016-03-21 09:50:52 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/15529)
4 years, 9 months ago (2016-03-21 11:09:47 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1820843002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1820843002/60001
4 years, 9 months ago (2016-03-21 12:22:02 UTC) #17
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 9 months ago (2016-03-21 13:33:07 UTC) #18
commit-bot: I haz the power
4 years, 9 months ago (2016-03-21 13:33:57 UTC) #20
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/9536c3886bc1537b81fb0f5823b443312d4fcc2c
Cr-Commit-Position: refs/heads/master@{#34937}

Powered by Google App Engine
This is Rietveld 408576698