Turn LoadIndexedInterceptor into a Turbofan stub

src/code-stubs.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/code-stubs.h"
 
 #include <sstream>
 
 #include "src/bootstrapper.h"
 #include "src/code-factory.h"
@@ skipping 2309 matching lines @@
 
       assembler->Bind(&if_valueisundetectable);
       assembler->Return(assembler->BooleanConstant(false));
 
       assembler->Bind(&if_valueisnotundetectable);
       assembler->Return(assembler->BooleanConstant(true));
     }
   }
 }
 
+void LoadIndexedInterceptorStub::GenerateAssembly(
+    compiler::CodeStubAssembler* assembler) const {
+  typedef compiler::Node Node;
+  typedef compiler::CodeStubAssembler::Label Label;
+  Node* receiver = assembler->Parameter(0);
+  Node* key = assembler->Parameter(1);
+  Node* slot = assembler->Parameter(2);
+  Node* vector = assembler->Parameter(3);
+  Node* context = assembler->Parameter(4);
+
+  Label if_keyissmi(assembler), if_keyisnotsmi(assembler);
+  assembler->Branch(assembler->WordIsSmi(key), &if_keyissmi, &if_keyisnotsmi);
+  assembler->Bind(&if_keyissmi);
+  {
+    Label if_keyvalid(assembler), if_keyinvalid(assembler);
+    assembler->BranchIfSmiLessThan(key, assembler->Int32Constant(0),

[Benedikt Meurer, 2016/03/21 09:36:56]

Nit: SmiConstant(0)

+                                   &if_keyvalid, &if_keyinvalid);
+    assembler->Bind(&if_keyvalid);
+    {
+      assembler->TailCallRuntime(Runtime::kLoadElementWithInterceptor, context,
+                                 receiver, key);
+    }
+
+    assembler->Bind(&if_keyinvalid);
+    assembler->TailCallRuntime(Runtime::kKeyedLoadIC_Miss, context, receiver,
+                               key, slot, vector);
+  }
+  assembler->Bind(&if_keyisnotsmi);
+  assembler->TailCallRuntime(Runtime::kKeyedLoadIC_Miss, context, receiver, key,

[Benedikt Meurer, 2016/03/21 09:36:56]

Nit: Add a merge Label and Goto to it from both cases.

+                             slot, vector);
+}
+
 void StoreInterceptorStub::GenerateAssembly(
     compiler::CodeStubAssembler* assembler) const {
   typedef compiler::Node Node;
   Node* receiver = assembler->Parameter(0);
   Node* name = assembler->Parameter(1);
   Node* value = assembler->Parameter(2);
   Node* context = assembler->Parameter(3);
   assembler->TailCallRuntime(Runtime::kStorePropertyWithInterceptor, context,
                              receiver, name, value);
 }
@@ skipping 426 matching lines @@
   if (type->Is(Type::UntaggedPointer())) {
     return Representation::External();
   }
 
   DCHECK(!type->Is(Type::Untagged()));
   return Representation::Tagged();
 }
 
 }  // namespace internal
 }  // namespace v8