Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 1820813004: Add UMA to HTMLCanvasElement to track image formats usage of toDataURL/toBlob (Closed)

Created:
4 years, 9 months ago by xlai (Olivia)
Modified:
4 years, 9 months ago
Reviewers:
jwd, Justin Novosad
CC:
chromium-reviews, dshwang, ajuma+watch-canvas_chromium.org, blink-reviews-html_chromium.org, dglazkov+blink, Rik, asvitkine+watch_chromium.org, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add UMA to HTMLCanvasElement to track image formats usage of toDataURL/toBlob BUG=596117 Committed: https://crrev.com/7b4d6fe2b7070127175b4086fc100e7c83dfbf10 Cr-Commit-Position: refs/heads/master@{#383176}

Patch Set 1 #

Patch Set 2 : Matching name of histogram #

Total comments: 6

Patch Set 3 : Changes based on feedback #

Total comments: 1

Patch Set 4 : Changes based on second feedback #

Total comments: 2

Patch Set 5 : Nits #

Total comments: 2

Patch Set 6 : Adding comment based on feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -6 lines) Patch
M third_party/WebKit/Source/core/html/HTMLCanvasElement.h View 1 2 3 4 1 chunk +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp View 1 2 3 4 5 3 chunks +46 lines, -5 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 3 chunks +26 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (6 generated)
xlai (Olivia)
Getting the usage of different image formats (e.g., png, jpeg, etc.) as returned from canvas ...
4 years, 9 months ago (2016-03-21 20:29:36 UTC) #4
Justin Novosad
https://codereview.chromium.org/1820813004/diff/20001/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp File third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp (right): https://codereview.chromium.org/1820813004/diff/20001/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp#newcode510 third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp:510: } else if (lowercaseMimeType == "image/bmp") { There is ...
4 years, 9 months ago (2016-03-22 15:09:04 UTC) #5
xlai (Olivia)
Changes based on feedback.
4 years, 9 months ago (2016-03-22 17:19:33 UTC) #6
Justin Novosad
https://codereview.chromium.org/1820813004/diff/40001/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp File third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp (right): https://codereview.chromium.org/1820813004/diff/40001/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp#newcode597 third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp:597: String encodingMimeType = toEncodingMimeType(mimeType, "toDataURL"); Replace this string arg ...
4 years, 9 months ago (2016-03-22 18:19:53 UTC) #7
xlai (Olivia)
Changes based on second feedback
4 years, 9 months ago (2016-03-22 19:42:37 UTC) #8
Justin Novosad
https://codereview.chromium.org/1820813004/diff/60001/third_party/WebKit/Source/core/html/HTMLCanvasElement.h File third_party/WebKit/Source/core/html/HTMLCanvasElement.h (right): https://codereview.chromium.org/1820813004/diff/60001/third_party/WebKit/Source/core/html/HTMLCanvasElement.h#newcode101 third_party/WebKit/Source/core/html/HTMLCanvasElement.h:101: enum RequestImageFunctionCallName { Naming nit, you can be more ...
4 years, 9 months ago (2016-03-22 20:23:02 UTC) #9
xlai (Olivia)
Nits
4 years, 9 months ago (2016-03-22 20:44:48 UTC) #10
jwd
https://codereview.chromium.org/1820813004/diff/80001/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp File third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp (right): https://codereview.chromium.org/1820813004/diff/80001/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp#newcode495 third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp:495: enum RequestedImageMimeType { Can you add a comment that ...
4 years, 9 months ago (2016-03-23 19:05:13 UTC) #11
Justin Novosad
https://codereview.chromium.org/1820813004/diff/80001/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp File third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp (right): https://codereview.chromium.org/1820813004/diff/80001/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp#newcode533 third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp:533: DEFINE_THREAD_SAFE_STATIC_LOCAL(EnumerationHistogram, toDataURLImageFormatHistogram, new EnumerationHistogram("Canvas.RequestedImageMimeTypes_toDataURL", NumberOfRequestedImageMimeTypes)); Are you sure it ...
4 years, 9 months ago (2016-03-23 19:35:48 UTC) #12
xlai (Olivia)
jwd@: Adding comments based on feedback. juno@: Yes, in the beginning of tools/metrics/histogram.xml, there is ...
4 years, 9 months ago (2016-03-23 19:42:06 UTC) #13
Justin Novosad
core/ lgtm
4 years, 9 months ago (2016-03-23 20:20:38 UTC) #14
jwd
lgtm
4 years, 9 months ago (2016-03-24 20:59:07 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1820813004/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1820813004/100001
4 years, 9 months ago (2016-03-24 21:00:45 UTC) #17
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 9 months ago (2016-03-24 22:59:51 UTC) #19
commit-bot: I haz the power
4 years, 9 months ago (2016-03-24 23:01:42 UTC) #21
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/7b4d6fe2b7070127175b4086fc100e7c83dfbf10
Cr-Commit-Position: refs/heads/master@{#383176}

Powered by Google App Engine
This is Rietveld 408576698