third_party/WebKit/Source/core/html/HTMLCanvasElement.h - Issue 1820813004: Add UMA to HTMLCanvasElement to track image formats usage of toDataURL/toBlob

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLCanvasElement.h

Issue 1820813004: Add UMA to HTMLCanvasElement to track image formats usage of toDataURL/toBlob (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Adding comment based on feedback Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/html/HTMLCanvasElement.h

diff --git a/third_party/WebKit/Source/core/html/HTMLCanvasElement.h b/third_party/WebKit/Source/core/html/HTMLCanvasElement.h

index e7bb8bbb4369218d4e700e60f7e7d6304a717fc2..6c8a1550804f99fdf8c333fda4058e6c05192116 100644

--- a/third_party/WebKit/Source/core/html/HTMLCanvasElement.h

+++ b/third_party/WebKit/Source/core/html/HTMLCanvasElement.h

@@ -98,7 +98,12 @@ public:

bool isPaintable() const;

- static String toEncodingMimeType(const String& mimeType);

+ enum EncodeReason {

+ EncodeReasonToDataURL = 0,

+ EncodeReasonToBlobCallback = 1,

+ NumberOfEncodeReasons

+ };

+ static String toEncodingMimeType(const String& mimeType, const EncodeReason);

String toDataURL(const String& mimeType, const ScriptValue& qualityArgument, ExceptionState&) const;

String toDataURL(const String& mimeType, ExceptionState& exceptionState) const { return toDataURL(mimeType, ScriptValue(), exceptionState); }

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp » ('j') | no next file with comments »