Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 1820763003: [Media Router WebUI] Handle on dialog load focus on Mac. (Closed)

Created:
4 years, 9 months ago by apacible
Modified:
4 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

[Media Router WebUI] Handle on dialog load focus on Mac. This change better handles the non-user-triggered focus event that happens when the dialog loads. The behavior only appears on Mac and when the dialog initially is opened; however, it appears 100% of the time in these cases. This adds an element with the sole purpose of triggering focus on that element when the dialog is open rather than any of the other header elements. This prevents messing with the tabindex (whether elements are focusable and in what priority) of the other elements. The tabindex of this element is then updated to be unfocusable so that the user cannot accidentally tab to the element. BUG=594951 Review URL: https://codereview.chromium.org/1807803002 Cr-Commit-Position: refs/heads/master@{#381851} (cherry picked from commit 48d7378cc2e2cc76c9cf0bfcd05413f8678662cb) Committed: https://chromium.googlesource.com/chromium/src/+/49bc338d56358c724d7a0b3a45d4573e43e0b6f3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -4 lines) Patch
M chrome/browser/resources/media_router/elements/media_router_header/media_router_header.html View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/resources/media_router/elements/media_router_header/media_router_header.js View 2 chunks +19 lines, -3 lines 0 comments Download
M chrome/test/data/webui/media_router/media_router_elements_browsertest.js View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
apacible
4 years, 9 months ago (2016-03-21 18:14:20 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
49bc338d56358c724d7a0b3a45d4573e43e0b6f3.

Powered by Google App Engine
This is Rietveld 408576698