[Media Router WebUI] Handle on dialog load focus on Mac.

[Media Router WebUI] Handle on dialog load focus on Mac.

This change better handles the non-user-triggered focus event that happens when the dialog loads. The behavior only appears on Mac and when the dialog initially is opened; however, it appears 100% of the time in these cases.

This adds an element with the sole purpose of triggering focus on that element when the dialog is open rather than any of the other header elements. This prevents messing with the tabindex (whether elements are focusable and in what priority) of the other elements. The tabindex of this element is then updated to be unfocusable so that the user cannot accidentally tab to the element.

BUG=594951
Committed: https://crrev.com/48d7378cc2e2cc76c9cf0bfcd05413f8678662cb
Cr-Commit-Position: refs/heads/master@{#381851}

[apacible, 2016-03-16 01:54:26]

Description was changed from

==========
asdf

BUG=
==========

to

==========
asdf

BUG=594951
==========

[apacible, 2016-03-16 01:57:19]

Description was changed from

==========
asdf

BUG=594951
==========

to

==========
[Media Router WebUI] Handle on dialog load focus on Mac.

BUG=594951
==========

[apacible, 2016-03-16 02:01:58]

Description was changed from

==========
[Media Router WebUI] Handle on dialog load focus on Mac.

BUG=594951
==========

to

==========
[Media Router WebUI] Handle on dialog load focus on Mac.

This change better handles the non-user-triggered focus event that happens when
the dialog loads. The behavior only appears on Mac and when the dialog initially
is opened; however, it appears 100% of the time in these cases.

This adds an element with the sole purpose of triggering focus on that element
when the dialog is open rather than any of the other header elements. This
prevents messing with the tabindex (whether elements are focusable and in what
priority) of the other elements. The tabindex of this element is then updated to
be unfocusable so that the user cannot accidentally tab to the element.

BUG=594951
==========

[apacible, 2016-03-16 19:22:03]

Patchset #4 (id:60001) has been deleted

[apacible, 2016-03-16 19:22:09]

Patchset #3 (id:40001) has been deleted

[apacible, 2016-03-16 19:23:20]

Patchset #2 (id:20001) has been deleted

[apacible, 2016-03-16 19:23:25]

Patchset #1 (id:1) has been deleted

[apacible, 2016-03-16 19:52:16]

Patchset #3 (id:120001) has been deleted

[apacible, 2016-03-16 20:49:17]

Patchset #2 (id:100001) has been deleted

[apacible, 2016-03-16 20:49:23]

Patchset #1 (id:80001) has been deleted

[apacible, 2016-03-16 20:49:34]

Patchset #1 (id:140001) has been deleted

[apacible, 2016-03-16 22:30:57]

Patchset #1 (id:160001) has been deleted

[apacible, 2016-03-16 22:53:53]

apacible@chromium.org changed reviewers:
+ imcheng@chromium.org

[apacible, 2016-03-16 22:54:28]

apacible@chromium.org changed reviewers:
- imcheng@chromium.org

[apacible, 2016-03-16 23:47:58]

apacible@chromium.org changed reviewers:
+ imcheng@chromium.org

[apacible, 2016-03-16 23:47:59]

PTAL, thanks!

[imcheng, 2016-03-17 19:00:35]

lgtm + 1 comment

https://codereview.chromium.org/1807803002/diff/180001/chrome/browser/resourc...
File
chrome/browser/resources/media_router/elements/media_router_header/media_router_header.js
(right):

https://codereview.chromium.org/1807803002/diff/180001/chrome/browser/resourc...
chrome/browser/resources/media_router/elements/media_router_header/media_router_header.js:184:
// this.$$('#focus-placeholder').setAttribute('tabindex', -1);
Uncomment this line? Also it sounds like we are setting tabIndex to -1 without
removing the element itself?

[apacible, 2016-03-17 21:51:25]

Patchset #2 (id:200001) has been deleted

[apacible, 2016-03-17 21:52:11]

https://codereview.chromium.org/1807803002/diff/180001/chrome/browser/resourc...
File
chrome/browser/resources/media_router/elements/media_router_header/media_router_header.js
(right):

https://codereview.chromium.org/1807803002/diff/180001/chrome/browser/resourc...
chrome/browser/resources/media_router/elements/media_router_header/media_router_header.js:184:
// this.$$('#focus-placeholder').setAttribute('tabindex', -1);
On 2016/03/17 19:00:35, imcheng wrote:
> Uncomment this line? Also it sounds like we are setting tabIndex to -1 without
> removing the element itself?

Removed. We're just removing the element, not updating the attribute.

[apacible, 2016-03-18 00:11:37]

Patchset #3 (id:240001) has been deleted

[apacible, 2016-03-18 00:15:30]

Patchset #3 (id:260001) has been deleted

[apacible, 2016-03-18 00:29:32]

The CQ bit was checked by apacible@chromium.org

[apacible, 2016-03-18 00:29:33]

The patchset sent to the CQ was uploaded after l-g-t-m from imcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/1807803002/#ps220001
(title: "Changes per imcheng@'s comments.")

[commit-bot: I haz the power, 2016-03-18 00:30:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1807803002/220001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1807803002/220001

[commit-bot: I haz the power, 2016-03-18 00:36:36]

Description was changed from

==========
[Media Router WebUI] Handle on dialog load focus on Mac.

This change better handles the non-user-triggered focus event that happens when
the dialog loads. The behavior only appears on Mac and when the dialog initially
is opened; however, it appears 100% of the time in these cases.

This adds an element with the sole purpose of triggering focus on that element
when the dialog is open rather than any of the other header elements. This
prevents messing with the tabindex (whether elements are focusable and in what
priority) of the other elements. The tabindex of this element is then updated to
be unfocusable so that the user cannot accidentally tab to the element.

BUG=594951
==========

to

==========
[Media Router WebUI] Handle on dialog load focus on Mac.

This change better handles the non-user-triggered focus event that happens when
the dialog loads. The behavior only appears on Mac and when the dialog initially
is opened; however, it appears 100% of the time in these cases.

This adds an element with the sole purpose of triggering focus on that element
when the dialog is open rather than any of the other header elements. This
prevents messing with the tabindex (whether elements are focusable and in what
priority) of the other elements. The tabindex of this element is then updated to
be unfocusable so that the user cannot accidentally tab to the element.

BUG=594951
==========

[commit-bot: I haz the power, 2016-03-18 00:36:38]

Committed patchset #2 (id:220001)

[commit-bot: I haz the power, 2016-03-18 00:37:40]

Description was changed from

==========
[Media Router WebUI] Handle on dialog load focus on Mac.

This change better handles the non-user-triggered focus event that happens when
the dialog loads. The behavior only appears on Mac and when the dialog initially
is opened; however, it appears 100% of the time in these cases.

This adds an element with the sole purpose of triggering focus on that element
when the dialog is open rather than any of the other header elements. This
prevents messing with the tabindex (whether elements are focusable and in what
priority) of the other elements. The tabindex of this element is then updated to
be unfocusable so that the user cannot accidentally tab to the element.

BUG=594951
==========

to

==========
[Media Router WebUI] Handle on dialog load focus on Mac.

This change better handles the non-user-triggered focus event that happens when
the dialog loads. The behavior only appears on Mac and when the dialog initially
is opened; however, it appears 100% of the time in these cases.

This adds an element with the sole purpose of triggering focus on that element
when the dialog is open rather than any of the other header elements. This
prevents messing with the tabindex (whether elements are focusable and in what
priority) of the other elements. The tabindex of this element is then updated to
be unfocusable so that the user cannot accidentally tab to the element.

BUG=594951

Committed: https://crrev.com/48d7378cc2e2cc76c9cf0bfcd05413f8678662cb
Cr-Commit-Position: refs/heads/master@{#381851}
==========

[commit-bot: I haz the power, 2016-03-18 00:37:41]

Patchset 2 (id:??) landed as
https://crrev.com/48d7378cc2e2cc76c9cf0bfcd05413f8678662cb
Cr-Commit-Position: refs/heads/master@{#381851}