Issue 18205009: Introduce isHTMLVideoElement and toHTMLVideoElement

Issue 18205009: Introduce isHTMLVideoElement and toHTMLVideoElement (Closed)

Created:
7 years, 5 months ago by kangil_

Modified:
7 years, 5 months ago

Reviewers:
abarth-chromium

CC:
blink-reviews, eae+blinkwatch, leviw+renderwatch, feature-media-reviews_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, adamk+blink_chromium.org, jchaffraix+rendering, darktears, vcarbune.chromium

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Introduce isHTMLVideoElement and toHTMLVideoElement To avoid direct use of static_cast, this patch introduces isHTMLVideoElement and toHTMLVideoElement for code cleanup. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154078

Patch Set 1 #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+35 lines, -14 lines)			Patch
M	Source/core/css/CSSDefaultStyleSheets.cpp	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	Source/core/html/HTMLImageLoader.cpp	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	Source/core/html/HTMLVideoElement.h	View	1 chunk	+16 lines, -0 lines	0 comments	Download
M	Source/core/html/MediaDocument.cpp	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	Source/core/html/shadow/MediaControlElements.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/rendering/HitTestResult.cpp	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	Source/core/rendering/RenderVideo.cpp	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	Source/web/ContextMenuClientImpl.cpp	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	Source/web/WebViewImpl.cpp	View	2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kangil.han@samsung.com/18205009/1

7 years, 5 months ago (2013-07-12 01:34:46 UTC) #2

commit-bot: I haz the power

Retried try job too often on linux_layout_rel for step(s) webkit_python_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=16362

7 years, 5 months ago (2013-07-12 02:08:21 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kangil.han@samsung.com/18205009/1

7 years, 5 months ago (2013-07-12 02:09:17 UTC) #4

Message was sent while issue was closed.

Change committed as 154078

Expand Messages | Collapse Messages