Source/web/ContextMenuClientImpl.cpp - Issue 18205009: Introduce isHTMLVideoElement and toHTMLVideoElement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/ContextMenuClientImpl.cpp

Issue 18205009: Introduce isHTMLVideoElement and toHTMLVideoElement (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/ContextMenuClientImpl.cpp

diff --git a/Source/web/ContextMenuClientImpl.cpp b/Source/web/ContextMenuClientImpl.cpp

index 059e0f9be2a64fad4db6301dac15f49c2ab5a487..c0f957c22dc68f73a22a862ab2583c037a966c28 100644

--- a/Source/web/ContextMenuClientImpl.cpp

+++ b/Source/web/ContextMenuClientImpl.cpp

@@ -54,6 +54,7 @@

#include "core/html/HTMLInputElement.h"

#include "core/html/HTMLMediaElement.h"

#include "core/html/HTMLPlugInImageElement.h"

+#include "core/html/HTMLVideoElement.h"

#include "core/html/MediaError.h"

#include "core/loader/DocumentLoader.h"

#include "core/loader/FrameLoader.h"

@@ -221,7 +222,7 @@ void ContextMenuClientImpl::showContextMenu(const WebCore::ContextMenu* defaultM

// is a media element.

HTMLMediaElement* mediaElement =

toMediaElement(r.innerNonSharedNode());

- if (mediaElement->hasTagName(HTMLNames::videoTag))

+ if (isHTMLVideoElement(mediaElement))

data.mediaType = WebContextMenuData::MediaTypeVideo;

else if (mediaElement->hasTagName(HTMLNames::audioTag))

data.mediaType = WebContextMenuData::MediaTypeAudio;

« no previous file with comments | « Source/core/rendering/RenderVideo.cpp ('k') | Source/web/WebViewImpl.cpp » ('j') | no next file with comments »