third_party/WebKit/Source/core/layout/LayoutInline.h - Issue 1820483002: Untangle multicol coordinate space conversion from offsetFromContainer().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutInline.h

Issue 1820483002: Untangle multicol coordinate space conversion from offsetFromContainer(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address code review comment. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutInline.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutInline.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutInline.h b/third_party/WebKit/Source/core/layout/LayoutInline.h

index 1df25d80c442895b73a0d44a2411a5bb9d39db0d..11a367cb8a4cbd50d942d59f376cea683393345e 100644

--- a/third_party/WebKit/Source/core/layout/LayoutInline.h

+++ b/third_party/WebKit/Source/core/layout/LayoutInline.h

@@ -140,7 +140,7 @@ public:

void absoluteRects(Vector<IntRect>&, const LayoutPoint& accumulatedOffset) const final;

void absoluteQuads(Vector<FloatQuad>&, bool* wasFixed) const override;

- LayoutSize offsetFromContainer(const LayoutObject*, const LayoutPoint&, bool* offsetDependsOnPoint = nullptr) const final;

+ LayoutSize offsetFromContainer(const LayoutObject*) const final;

IntRect linesBoundingBox() const;

LayoutRect visualOverflowRect() const final;