Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutInline.h

Issue 1820483002: Untangle multicol coordinate space conversion from offsetFromContainer(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address code review comment. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved. 4 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 122 matching lines...) Expand 10 before | Expand all | Expand 10 after
133 LayoutUnit marginBefore(const ComputedStyle* otherStyle = nullptr) const fin al; 133 LayoutUnit marginBefore(const ComputedStyle* otherStyle = nullptr) const fin al;
134 LayoutUnit marginAfter(const ComputedStyle* otherStyle = nullptr) const fina l; 134 LayoutUnit marginAfter(const ComputedStyle* otherStyle = nullptr) const fina l;
135 LayoutUnit marginStart(const ComputedStyle* otherStyle = nullptr) const fina l; 135 LayoutUnit marginStart(const ComputedStyle* otherStyle = nullptr) const fina l;
136 LayoutUnit marginEnd(const ComputedStyle* otherStyle = nullptr) const final; 136 LayoutUnit marginEnd(const ComputedStyle* otherStyle = nullptr) const final;
137 LayoutUnit marginOver() const final; 137 LayoutUnit marginOver() const final;
138 LayoutUnit marginUnder() const final; 138 LayoutUnit marginUnder() const final;
139 139
140 void absoluteRects(Vector<IntRect>&, const LayoutPoint& accumulatedOffset) c onst final; 140 void absoluteRects(Vector<IntRect>&, const LayoutPoint& accumulatedOffset) c onst final;
141 void absoluteQuads(Vector<FloatQuad>&, bool* wasFixed) const override; 141 void absoluteQuads(Vector<FloatQuad>&, bool* wasFixed) const override;
142 142
143 LayoutSize offsetFromContainer(const LayoutObject*, const LayoutPoint&, bool * offsetDependsOnPoint = nullptr) const final; 143 LayoutSize offsetFromContainer(const LayoutObject*) const final;
144 144
145 IntRect linesBoundingBox() const; 145 IntRect linesBoundingBox() const;
146 LayoutRect visualOverflowRect() const final; 146 LayoutRect visualOverflowRect() const final;
147 147
148 InlineFlowBox* createAndAppendInlineFlowBox(); 148 InlineFlowBox* createAndAppendInlineFlowBox();
149 149
150 void dirtyLineBoxes(bool fullLayout); 150 void dirtyLineBoxes(bool fullLayout);
151 151
152 LineBoxList* lineBoxes() { return &m_lineBoxes; } 152 LineBoxList* lineBoxes() { return &m_lineBoxes; }
153 const LineBoxList* lineBoxes() const { return &m_lineBoxes; } 153 const LineBoxList* lineBoxes() const { return &m_lineBoxes; }
(...skipping 121 matching lines...) Expand 10 before | Expand all | Expand 10 after
275 275
276 LayoutObjectChildList m_children; 276 LayoutObjectChildList m_children;
277 LineBoxList m_lineBoxes; // All of the line boxes created for this inline fl ow. For example, <i>Hello<br>world.</i> will have two <i> line boxes. 277 LineBoxList m_lineBoxes; // All of the line boxes created for this inline fl ow. For example, <i>Hello<br>world.</i> will have two <i> line boxes.
278 }; 278 };
279 279
280 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutInline, isLayoutInline()); 280 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutInline, isLayoutInline());
281 281
282 } // namespace blink 282 } // namespace blink
283 283
284 #endif // LayoutInline_h 284 #endif // LayoutInline_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutInline.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698