Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 1820393002: DevTools: [ux regression] There is no way to clear console history. (Closed)

Created:
4 years, 9 months ago by pfeldman
Modified:
4 years, 9 months ago
Reviewers:
dgozman, lushnikov
CC:
chromium-reviews, extensions-reviews_chromium.org, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, chromium-apps-reviews_chromium.org, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: [ux regression] There is no way to clear console history. BUG=594342 Committed: https://crrev.com/a7467383c208ef2e5a90d8e20979b6ba722ac104 Cr-Commit-Position: refs/heads/master@{#383174}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -95 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/console-show-all-messages.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/console-test.js View 15 chunks +16 lines, -16 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/console/console-links-on-messages-before-inspection.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/stacktraces/resources/stacktrace-test.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector-enabled/sources/debugger/script-formatter-console.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-big-array.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-copy-treeoutline.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-custom-formatters.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-edit-expanded-tree.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-eval-exception-report.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-filter-level-test.html View 2 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-filter-test.html View 2 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-format-broken-unicode.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-linkify-message-location.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-log-linkify-links.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-search.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-search-reveals-messages.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-stack-overflow.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-uncaught-exception-in-eval.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-viewport-selection.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-viewport-stick-to-bottom.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/extensions/extensions-panel.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/extensions/extensions-reload.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/show-function-definition.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/Tests.js View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/console/ConsolePanel.js View 4 chunks +4 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js View 4 chunks +20 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/console/module.json View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/source_frame/TextEditorAutocompleteController.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/FilterBar.js View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/SuggestBox.js View 1 7 chunks +13 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js View 1 2 3 6 chunks +18 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/suggestBox.css View 1 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (9 generated)
pfeldman
4 years, 9 months ago (2016-03-22 17:54:52 UTC) #2
lushnikov
lgtm
4 years, 9 months ago (2016-03-22 19:16:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1820393002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1820393002/1
4 years, 9 months ago (2016-03-22 19:18:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1820393002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1820393002/1
4 years, 9 months ago (2016-03-22 21:58:30 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/159842)
4 years, 9 months ago (2016-03-22 22:06:32 UTC) #10
pbakaus
What's the actual solution here?
4 years, 9 months ago (2016-03-23 01:45:33 UTC) #11
pfeldman
PTAL last 3 files again.
4 years, 9 months ago (2016-03-24 18:04:59 UTC) #13
dgozman
lgtm https://codereview.chromium.org/1820393002/diff/40001/third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js File third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js (right): https://codereview.chromium.org/1820393002/diff/40001/third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js#newcode474 third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js:474: * @return {!Array.<{title: string, className: (string|undefined)}>} WebInspector.SuggestBox.Suggestions https://codereview.chromium.org/1820393002/diff/40001/third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js#newcode832 ...
4 years, 9 months ago (2016-03-24 18:39:34 UTC) #14
pfeldman
All done.
4 years, 9 months ago (2016-03-24 21:28:18 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1820393002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1820393002/60001
4 years, 9 months ago (2016-03-24 21:28:40 UTC) #18
lushnikov
A screenshot would be very helpful
4 years, 9 months ago (2016-03-24 21:44:44 UTC) #19
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 9 months ago (2016-03-24 22:50:41 UTC) #20
commit-bot: I haz the power
4 years, 9 months ago (2016-03-24 22:51:19 UTC) #22
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/a7467383c208ef2e5a90d8e20979b6ba722ac104
Cr-Commit-Position: refs/heads/master@{#383174}

Powered by Google App Engine
This is Rietveld 408576698