Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(741)

Unified Diff: third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js

Issue 1820393002: DevTools: [ux regression] There is no way to clear console history. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js b/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
index da86d912bc5cd629764ed63f452461ad09485839..851347821a0a0bdcd6a16647d46b3fa8070f14f8 100644
--- a/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
+++ b/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
@@ -164,6 +164,12 @@ WebInspector.ConsoleView.prototype = {
return this._searchableView;
},
+ _clearHistory: function()
+ {
+ this._consoleHistorySetting.set([]);
+ this._prompt.setHistoryData([]);
+ },
+
/**
* @param {!WebInspector.Event} event
*/
@@ -578,6 +584,7 @@ WebInspector.ConsoleView.prototype = {
contextMenu.appendSeparator();
contextMenu.appendAction("console.clear");
+ contextMenu.appendAction("console.clear.history");
contextMenu.appendItem(WebInspector.UIString("Save as..."), this._saveConsole.bind(this));
var request = consoleMessage ? consoleMessage.request : null;
@@ -1275,6 +1282,16 @@ WebInspector.ConsoleGroup.prototype = {
}
/**
+ * @return {!WebInspector.ConsoleView}
+ */
+WebInspector.ConsoleView.instance = function()
+{
+ if (!WebInspector.ConsoleView._instance)
+ WebInspector.ConsoleView._instance = new WebInspector.ConsoleView();
+ return WebInspector.ConsoleView._instance;
+}
+
+/**
* @constructor
* @implements {WebInspector.ActionDelegate}
*/
@@ -1298,6 +1315,9 @@ WebInspector.ConsoleView.ActionDelegate.prototype = {
case "console.clear":
WebInspector.ConsoleModel.clearConsole();
return true;
+ case "console.clear.history":
+ WebInspector.ConsoleView.instance()._clearHistory();
+ return true;
}
return false;
}

Powered by Google App Engine
This is Rietveld 408576698