Directly use GrGLInterface in cc tests rather than SkNullGLContext

Directly use GrGLInterface in cc tests rather than SkNullGLContext.

This unblocks removal of SkGLContext and its subclasses from the Skia lib. Using the null GrGLInterface here used to be problematic because its implementation stored its state globally, assuming there was only one instance. This is no longer the case.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/8799bb02c20d52878bde3eb9e2e33138919233ac
Cr-Commit-Position: refs/heads/master@{#383375}

[bsalomon, 2016-03-25 14:45:01]

Description was changed from

==========
Directly use GrGLInterface in cc tests rather than SkNullGLContext
==========

to

==========
Directly use GrGLInterface in cc tests rather than SkNullGLContext
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[bsalomon, 2016-03-25 14:51:49]

Description was changed from

==========
Directly use GrGLInterface in cc tests rather than SkNullGLContext
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Directly use GrGLInterface in cc tests rather than SkNullGLContext.

This unblocks removal of SkGLContext and its subclasses from the Skia lib. Using
the null GrGLInterface here used to be problematic because its implementation
stored its state globally, assuming there was only one instance. This is no
longer the case.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[bsalomon, 2016-03-25 14:51:49]

bsalomon@google.com changed reviewers:
+ danakj@chromium.org, enne@chromium.org

[bsalomon, 2016-03-25 14:52:17]

PTAL, very small change.

[bsalomon, 2016-03-25 15:06:43]

+junov@ for Canvas2DLayerBridgeTest change.

[bsalomon, 2016-03-25 15:06:58]

bsalomon@google.com changed reviewers:
+ junov@chromium.org

[bsalomon, 2016-03-25 15:07:07]

On 2016/03/25 15:06:43, bsalomon wrote:
> +junov@ for Canvas2DLayerBridgeTest change.

for real, this time.

[enne (OOO), 2016-03-25 17:09:30]

lgtm

[bsalomon, 2016-03-25 17:18:20]

bsalomon@google.com changed reviewers:
+ fmalita@chromium.org

[bsalomon, 2016-03-25 17:18:21]

+Florin since Montreal is off today.

[danakj, 2016-03-25 18:09:36]

LGTM

https://codereview.chromium.org/1829363003/diff/40001/cc/test/test_context_pr...
File cc/test/test_context_provider.cc (right):

https://codereview.chromium.org/1829363003/diff/40001/cc/test/test_context_pr...
cc/test/test_context_provider.cc:115: auto gl_interface =
skia::AdoptRef(GrGLCreateNullInterface());
re: past chromium-dev threads, don't use auto for smart pointers.

[f(malita), 2016-03-25 18:19:47]

lgtm

[bsalomon, 2016-03-25 19:02:45]

https://codereview.chromium.org/1829363003/diff/40001/cc/test/test_context_pr...
File cc/test/test_context_provider.cc (right):

https://codereview.chromium.org/1829363003/diff/40001/cc/test/test_context_pr...
cc/test/test_context_provider.cc:115: auto gl_interface =
skia::AdoptRef(GrGLCreateNullInterface());
On 2016/03/25 18:09:36, danakj wrote:
> re: past chromium-dev threads, don't use auto for smart pointers.
Done.

[bsalomon, 2016-03-25 19:03:18]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2016-03-25 19:03:18]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org,
fmalita@chromium.org, enne@chromium.org
Link to the patchset: https://codereview.chromium.org/1829363003/#ps60001
(title: "no auto for smart ptr")

[commit-bot: I haz the power, 2016-03-25 19:03:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1829363003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1829363003/60001

[commit-bot: I haz the power, 2016-03-25 21:59:41]

Description was changed from

==========
Directly use GrGLInterface in cc tests rather than SkNullGLContext.

This unblocks removal of SkGLContext and its subclasses from the Skia lib. Using
the null GrGLInterface here used to be problematic because its implementation
stored its state globally, assuming there was only one instance. This is no
longer the case.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Directly use GrGLInterface in cc tests rather than SkNullGLContext.

This unblocks removal of SkGLContext and its subclasses from the Skia lib. Using
the null GrGLInterface here used to be problematic because its implementation
stored its state globally, assuming there was only one instance. This is no
longer the case.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[commit-bot: I haz the power, 2016-03-25 21:59:42]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-03-25 22:02:21]

Description was changed from

==========
Directly use GrGLInterface in cc tests rather than SkNullGLContext.

This unblocks removal of SkGLContext and its subclasses from the Skia lib. Using
the null GrGLInterface here used to be problematic because its implementation
stored its state globally, assuming there was only one instance. This is no
longer the case.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Directly use GrGLInterface in cc tests rather than SkNullGLContext.

This unblocks removal of SkGLContext and its subclasses from the Skia lib. Using
the null GrGLInterface here used to be problematic because its implementation
stored its state globally, assuming there was only one instance. This is no
longer the case.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/8799bb02c20d52878bde3eb9e2e33138919233ac
Cr-Commit-Position: refs/heads/master@{#383375}
==========

[commit-bot: I haz the power, 2016-03-25 22:02:22]

Patchset 4 (id:??) landed as
https://crrev.com/8799bb02c20d52878bde3eb9e2e33138919233ac
Cr-Commit-Position: refs/heads/master@{#383375}