Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 1819473002: Generate Blink's Mojo bindings both for regular and WTF variants (Closed)

Created:
4 years, 9 months ago by Peter Beverloo
Modified:
4 years, 9 months ago
Reviewers:
haraken, esprehn, yzshen1
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/src.git@n-mojo-mojom
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Generate Blink's Mojo bindings both for regular and WTF variants Mojo files defined in the API boundary will most likely be consumed from both within and outside of Blink. This generates them both in the regular variant, backed by the Mojo (STL) times, and the WTF variant. I chose to use "wtf" as the variant rather than "blink" because of the namespacing that's already in place: "blink::mojom::wtf::*" vs. "blink::mojom::blink::*". BUG=595685 Committed: https://crrev.com/e73b1ec08b8d1dbde884f58a7a2c6cbbbccfa6ed Cr-Commit-Position: refs/heads/master@{#382761}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -7 lines) Patch
M third_party/WebKit/public/BUILD.gn View 1 1 chunk +11 lines, -0 lines 0 comments Download
M third_party/WebKit/public/blink.gyp View 1 2 chunks +25 lines, -7 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (4 generated)
Peter Beverloo
+yzshen for Mojo, esprehn for Blink
4 years, 9 months ago (2016-03-22 11:57:19 UTC) #2
yzshen1
On 2016/03/22 11:57:19, Peter Beverloo wrote: > +yzshen for Mojo, esprehn for Blink LGTM I ...
4 years, 9 months ago (2016-03-22 15:54:23 UTC) #3
Peter Beverloo
+haraken
4 years, 9 months ago (2016-03-22 23:05:40 UTC) #5
haraken
LGTM
4 years, 9 months ago (2016-03-22 23:28:12 UTC) #6
esprehn
lgtm
4 years, 9 months ago (2016-03-23 00:35:13 UTC) #7
Peter Beverloo
Thank you!
4 years, 9 months ago (2016-03-23 00:37:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1819473002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1819473002/20001
4 years, 9 months ago (2016-03-23 00:38:23 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-23 01:24:25 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-23 01:25:52 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e73b1ec08b8d1dbde884f58a7a2c6cbbbccfa6ed
Cr-Commit-Position: refs/heads/master@{#382761}

Powered by Google App Engine
This is Rietveld 408576698