Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1814813002: Define a Mojo Notification structure in the Blink API (Closed)

Created:
4 years, 9 months ago by Peter Beverloo
Modified:
4 years, 9 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, darin (slow to review), dglazkov+blink, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Define a Mojo Notification structure in the Blink API This will replace the PlatformNotification{Action, Data} structures that currently live in //content. It's based on a similar CL for Web Bluetooth: https://codereview.chromium.org/1784613002/ The stack will be switched over in a next CL. Since it's part of a larger-scale refactoring, I'd like to land this separately to unblock other people that will depend on this. BUG=595685 Committed: https://crrev.com/2263dd5457199da3e51086903f0a1caec6bd86d4 Cr-Commit-Position: refs/heads/master@{#382564}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -0 lines) Patch
M third_party/WebKit/public/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/public/blink.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/public/platform/modules/notifications/notification.mojom View 1 1 chunk +77 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (6 generated)
Peter Beverloo
+mvanouwerkerk for notifications +esprehn for the API Elliott, until modules can use use Mojo and ...
4 years, 9 months ago (2016-03-17 14:24:55 UTC) #3
Michael van Ouwerkerk
lgtm ship it
4 years, 9 months ago (2016-03-17 14:38:30 UTC) #4
esprehn
You can depend on mojo today, see the blink-dev email for how to generate WTF ...
4 years, 9 months ago (2016-03-17 20:19:07 UTC) #5
Peter Beverloo
Because Chrome doesn't use time as a double. Nonetheless, it doesn't matter whether I do ...
4 years, 9 months ago (2016-03-18 17:55:34 UTC) #6
Peter Beverloo
Elliott: Friendly ping.
4 years, 9 months ago (2016-03-21 15:12:52 UTC) #7
esprehn
lgtm
4 years, 9 months ago (2016-03-21 20:32:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1814813002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1814813002/20001
4 years, 9 months ago (2016-03-22 10:41:52 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-22 13:35:30 UTC) #13
commit-bot: I haz the power
4 years, 9 months ago (2016-03-22 13:36:35 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2263dd5457199da3e51086903f0a1caec6bd86d4
Cr-Commit-Position: refs/heads/master@{#382564}

Powered by Google App Engine
This is Rietveld 408576698