mojo/public/cpp/bindings/tests/binding_callback_unittest.cc - Issue 1819463002: Make mojo::Callback safe to copy across threads.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/cpp/bindings/tests/binding_callback_unittest.cc

Issue 1819463002: Make mojo::Callback safe to copy across threads. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix destruction. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/public/cpp/bindings/tests/binding_callback_unittest.cc

diff --git a/mojo/public/cpp/bindings/tests/binding_callback_unittest.cc b/mojo/public/cpp/bindings/tests/binding_callback_unittest.cc

index 8dbdb8cc7556e61cf5648d4a31d9570f8b4de2a9..eb5190477e55a769ff79d381e7d371248759efd5 100644

--- a/mojo/public/cpp/bindings/tests/binding_callback_unittest.cc

+++ b/mojo/public/cpp/bindings/tests/binding_callback_unittest.cc

@@ -338,7 +338,7 @@ TEST_F(BindingCallbackTest, DeleteCallbackBeforeBindingDeathTest) {

#if !defined(NDEBUG) || defined(DCHECK_ALWAYS_ON)

// Delete the callback without running it. This should cause a crash in debug

// builds due to a DCHECK.

- std::string regex("Check failed: !callback_was_dropped.");

+ std::string regex("Check failed: false");

#if defined(OS_WIN)

// TODO(msw): Fix MOJO_DCHECK logs and EXPECT_DEATH* on Win: crbug.com/535014

regex.clear();