Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1944)

Unified Diff: mojo/public/cpp/bindings/message.h

Issue 1819463002: Make mojo::Callback safe to copy across threads. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix destruction. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/public/cpp/bindings/message.h
diff --git a/mojo/public/cpp/bindings/message.h b/mojo/public/cpp/bindings/message.h
index 4b8014a895e5cd954a2c98958e1c1bba3d75f4af..2813093ce65a756aeda9184e34d6306ffe444e41 100644
--- a/mojo/public/cpp/bindings/message.h
+++ b/mojo/public/cpp/bindings/message.h
@@ -137,6 +137,10 @@ class MessageReceiverWithStatus : public MessageReceiver {
// Returns |true| if this MessageReceiver is currently bound to a MessagePipe,
// the pipe has not been closed, and the pipe has not encountered an error.
virtual bool IsValid() = 0;
yzshen1 2016/03/18 23:47:04 Is this method still needed?
Anand Mistry (off Chromium) 2016/03/19 01:02:13 Yes... for unittests. I'll leave it in for now and
+
+ // DCHECKs if this MessageReceiver is currently bound to a MessagePipe, the
+ // pipe has not been closed, and the pipe has not encountered an error.
yzshen1 2016/03/18 23:47:04 Could you please comment that this may be called f
Anand Mistry (off Chromium) 2016/03/19 01:02:13 Done.
+ virtual void DCheckValid(const std::string& message) {}
};
// An alternative to MessageReceiverWithResponder for cases in which it

Powered by Google App Engine
This is Rietveld 408576698