Source/platform/graphics/cpu/arm/filters/FELightingNEON.h - Issue 181943003: Scaling and offset fix for FELighting (software and skia paths)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/graphics/cpu/arm/filters/FELightingNEON.h

Issue 181943003: Scaling and offset fix for FELighting (software and skia paths) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fixed related Layout Tests to avoid rebaselining Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/svg/dynamic-updates/script-tests/SVGFESpotLightElement-svgdom-z-prop.js ('k') | Source/platform/graphics/filters/DistantLightSource.h » ('j') | Source/platform/graphics/filters/FELighting.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/platform/graphics/cpu/arm/filters/FELightingNEON.h

diff --git a/Source/platform/graphics/cpu/arm/filters/FELightingNEON.h b/Source/platform/graphics/cpu/arm/filters/FELightingNEON.h

index 69939a582a45979950f91ce505605e76da32cf19..828fcf3859f9454428b49e474cbc8254942b8e14 100644

--- a/Source/platform/graphics/cpu/arm/filters/FELightingNEON.h

+++ b/Source/platform/graphics/cpu/arm/filters/FELightingNEON.h

@@ -151,6 +151,12 @@ inline void FELighting::platformApplyNeon(LightingData& data, LightSource::Paint

floatArguments.padding2 = 1;

}

+ floatArguments.lightX *= data.worldScale.x();

+ floatArguments.lightY *= data.worldScale.y();

+ floatArguments.lightZ *= data.worldScale.z();

+ floatArguments.lightX -= data.originOffset.width();

+ floatArguments.lightY -= data.originOffset.height();

// Set lighting arguments.

floatArguments.surfaceScale = data.surfaceScale;

floatArguments.minusSurfaceScaleDividedByFour = -data.surfaceScale / 4;