Source/platform/graphics/filters/PointLightSource.cpp - Issue 181943003: Scaling and offset fix for FELighting (software and skia paths)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/graphics/filters/PointLightSource.cpp

Issue 181943003: Scaling and offset fix for FELighting (software and skia paths) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/platform/graphics/filters/FELighting.cpp ('K') | « Source/platform/graphics/filters/PointLightSource.h ('k') | Source/platform/graphics/filters/SpotLightSource.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/platform/graphics/filters/PointLightSource.cpp

diff --git a/Source/platform/graphics/filters/PointLightSource.cpp b/Source/platform/graphics/filters/PointLightSource.cpp

index c88c2ea4b19b670717d2db1346402cb1f00121e8..2a7dc880e4a60eb8480f2715ca5426f9b5511bc6 100644

--- a/Source/platform/graphics/filters/PointLightSource.cpp

+++ b/Source/platform/graphics/filters/PointLightSource.cpp

@@ -35,11 +35,11 @@

namespace WebCore {

-void PointLightSource::initPaintingData(PaintingData&)

+void PointLightSource::initPaintingData(PaintingData&) const

{

}

-void PointLightSource::updatePaintingData(PaintingData& paintingData, int x, int y, float z)

+void PointLightSource::updatePaintingData(PaintingData& paintingData, float x, float y, float z) const

{

paintingData.lightVector.setX(m_position.x() - x);

paintingData.lightVector.setY(m_position.y() - y);