Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1819353002: Convert GN group targets to Visual Studio projects (Closed)

Created:
4 years, 9 months ago by Tomasz Moniuszko
Modified:
4 years, 9 months ago
Reviewers:
brettw
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert GN group targets to Visual Studio projects BUG=596895 Committed: https://crrev.com/130612c0259b1200a8edf41973b058d5164470ef Cr-Commit-Position: refs/heads/master@{#383042}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -6 lines) Patch
M tools/gn/visual_studio_writer.cc View 3 chunks +9 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Tomasz Moniuszko
4 years, 9 months ago (2016-03-22 15:30:33 UTC) #2
brettw
lgtm
4 years, 9 months ago (2016-03-23 18:26:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1819353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1819353002/1
4 years, 9 months ago (2016-03-24 08:24:22 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-24 08:54:08 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-24 08:55:23 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/130612c0259b1200a8edf41973b058d5164470ef
Cr-Commit-Position: refs/heads/master@{#383042}

Powered by Google App Engine
This is Rietveld 408576698