Convert GN group targets to Visual Studio projects

tools/gn/visual_studio_writer.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "tools/gn/visual_studio_writer.h"
 
 #include <algorithm>
 #include <map>
 #include <set>
 #include <string>
@@ skipping 107 matching lines @@
 std::string GetConfigurationType(const Target* target, Err* err) {
   switch (target->output_type()) {
     case Target::EXECUTABLE:
       return "Application";
     case Target::SHARED_LIBRARY:
     case Target::LOADABLE_MODULE:
       return "DynamicLibrary";
     case Target::STATIC_LIBRARY:
     case Target::SOURCE_SET:
       return "StaticLibrary";
+    case Target::GROUP:
+      return "Utility";
 
     default:
       *err = Err(Location(),
                  "Visual Studio doesn't support '" + target->label().name() +
                      "' target output type: " +
                      Target::GetStringForOutputType(target->output_type()));
       return std::string();
   }
 }
 
@@ skipping 114 matching lines @@
     if (target_cpu_value != nullptr &&
         target_cpu_value->string_value() == "x64")
       config_platform = "x64";
   }
 
   VisualStudioWriter writer(build_settings, config_platform, version);
   writer.projects_.reserve(targets.size());
   writer.folders_.reserve(targets.size());
 
   for (const Target* target : targets) {
-    // Skip actions, groups and bundle targets.
-    if (target->output_type() == Target::GROUP ||
-        target->output_type() == Target::COPY_FILES ||
+    // Skip actions and bundle targets.
+    if (target->output_type() == Target::COPY_FILES ||
         target->output_type() == Target::ACTION ||
         target->output_type() == Target::ACTION_FOREACH ||
         target->output_type() == Target::BUNDLE_DATA) {
       continue;
     }
 
     if (!writer.WriteProjectFiles(target, err))
       return false;
   }
 
@@ skipping 142 matching lines @@
 
   project.SubElement("PropertyGroup", XmlAttributes("Label", "UserMacros"));
 
   {
     scoped_ptr<XmlElementWriter> properties =
         project.SubElement("PropertyGroup");
     {
       scoped_ptr<XmlElementWriter> out_dir = properties->SubElement("OutDir");
       path_output.WriteDir(out_dir->StartContent(false),
                            build_settings_->build_dir(),
-                           PathOutput::DIR_INCLUDE_LAST_SLASH);
+                           PathOutput::DIR_NO_LAST_SLASH);
     }
     properties->SubElement("TargetName")->Text("$(ProjectName)");
-    properties->SubElement("TargetPath")
-        ->Text("$(OutDir)\\$(ProjectName)$(TargetExt)");
+    if (target->output_type() != Target::GROUP) {
+      properties->SubElement("TargetPath")
+          ->Text("$(OutDir)\\$(ProjectName)$(TargetExt)");
+    }
   }
 
   {
     scoped_ptr<XmlElementWriter> item_definitions =
         project.SubElement("ItemDefinitionGroup");
     {
       scoped_ptr<XmlElementWriter> cl_compile =
           item_definitions->SubElement("ClCompile");
       {
         scoped_ptr<XmlElementWriter> include_dirs =
@@ skipping 349 matching lines @@
   }
 }
 
 std::string VisualStudioWriter::GetNinjaTarget(const Target* target) {
   std::ostringstream ninja_target_out;
   DCHECK(!target->dependency_output_file().value().empty());
   ninja_path_output_.WriteFile(ninja_target_out,
                                target->dependency_output_file());
   return ninja_target_out.str();
 }