Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(661)

Issue 1819243002: [DevTools] Use InspectorFrontendHost.readyForTest for layout tests. (Closed)

Created:
4 years, 9 months ago by dgozman
Modified:
4 years, 9 months ago
Reviewers:
pfeldman, battre
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, caseq+blink_chromium.org, mlamouri+watch-test-runner_chromium.org, Peter Beverloo, jam, lushnikov+blink_chromium.org, blink-reviews-api_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, darin-cc_chromium.org, pfeldman, devtools-reviews_chromium.org, blink-reviews, apavlov+blink_chromium.org, mkwst+moarreviews-shell_chromium.org, sergeyv+blink_chromium.org, jochen+watch_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@ready-for-test
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Use InspectorFrontendHost.readyForTest for layout tests. Attempt #2. First one made http/tests/inspector/resource-tree/resource-tree-reload.html flaky. BUG=597572 Committed: https://crrev.com/bdb67c0b431bf1726f0d91626c952086a4346c5c Cr-Commit-Position: refs/heads/master@{#383238}

Patch Set 1 #

Patch Set 2 : fprintf #

Patch Set 3 : test fix #

Patch Set 4 : resource-tree-reload.html fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -90 lines) Patch
M chrome/browser/devtools/devtools_window.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/devtools/devtools_window.cc View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/devtools/devtools_window_testing.cc View 1 2 1 chunk +6 lines, -4 lines 0 comments Download
M components/test_runner/web_test_delegate.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/shell/browser/layout_test/blink_test_controller.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/browser/layout_test/blink_test_controller.cc View 1 2 3 2 chunks +8 lines, -0 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_devtools_frontend.h View 2 chunks +7 lines, -0 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_devtools_frontend.cc View 1 3 chunks +45 lines, -1 line 0 comments Download
M content/shell/browser/shell_devtools_frontend.h View 2 chunks +1 line, -2 lines 0 comments Download
M content/shell/common/shell_messages.h View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M content/shell/renderer/layout_test/blink_test_runner.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/shell/renderer/layout_test/blink_test_runner.cc View 1 2 3 1 chunk +3 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector-protocol/resources/protocol-test.html View 3 chunks +21 lines, -16 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/resource-tree/resource-tree-reload.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/json-parse.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorInspectorAgent.h View 2 chunks +0 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorInspectorAgent.cpp View 1 chunk +0 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/devtools.js View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/host/InspectorFrontendHostAPI.js View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/main/Main.js View 1 2 2 chunks +11 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/devtools/protocol.json View 1 2 1 chunk +0 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/web/WebDevToolsAgentImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/public/web/WebDevToolsAgent.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 25 (12 generated)
dgozman
Take a look please.
4 years, 9 months ago (2016-03-22 00:57:21 UTC) #2
pfeldman
lgtm
4 years, 9 months ago (2016-03-23 19:02:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1819243002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1819243002/20001
4 years, 9 months ago (2016-03-23 19:18:08 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/135001)
4 years, 9 months ago (2016-03-23 20:13:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1819243002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1819243002/40001
4 years, 9 months ago (2016-03-23 22:57:54 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-24 02:12:41 UTC) #11
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/89f7238cebbf5d77e4caa84d0a2750f6faa7e983 Cr-Commit-Position: refs/heads/master@{#383015}
4 years, 9 months ago (2016-03-24 02:14:07 UTC) #13
battre
Please create bugs for features. I am going to revert this because I have seen ...
4 years, 9 months ago (2016-03-24 11:46:29 UTC) #15
battre
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/1828983002/ by battre@chromium.org. ...
4 years, 9 months ago (2016-03-24 11:51:47 UTC) #16
dgozman
On 2016/03/24 11:46:29, battre wrote: > Please create bugs for features. This is not a ...
4 years, 9 months ago (2016-03-24 17:08:34 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1819243002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1819243002/60001
4 years, 9 months ago (2016-03-25 01:13:30 UTC) #21
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 9 months ago (2016-03-25 03:32:39 UTC) #23
commit-bot: I haz the power
4 years, 9 months ago (2016-03-25 03:33:55 UTC) #25
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/bdb67c0b431bf1726f0d91626c952086a4346c5c
Cr-Commit-Position: refs/heads/master@{#383238}

Powered by Google App Engine
This is Rietveld 408576698