content/shell/browser/layout_test/blink_test_controller.cc - Issue 1819243002: [DevTools] Use InspectorFrontendHost.readyForTest for layout tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/browser/layout_test/blink_test_controller.cc

Issue 1819243002: [DevTools] Use InspectorFrontendHost.readyForTest for layout tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ready-for-test

Patch Set: resource-tree-reload.html fix Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/shell/browser/layout_test/blink_test_controller.h ('k') | content/shell/browser/layout_test/layout_test_devtools_frontend.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/browser/layout_test/blink_test_controller.cc

diff --git a/content/shell/browser/layout_test/blink_test_controller.cc b/content/shell/browser/layout_test/blink_test_controller.cc

index 87a286f6561e618e77b704948e068f374e2b95a5..2a5d083e015dc0a7c9d3435d6ca6c379f24b2155 100644

--- a/content/shell/browser/layout_test/blink_test_controller.cc

+++ b/content/shell/browser/layout_test/blink_test_controller.cc

@@ -413,6 +413,8 @@ bool BlinkTestController::OnMessageReceived(const IPC::Message& message) {

IPC_MESSAGE_HANDLER(ShellViewHostMsg_ClearDevToolsLocalStorage,

OnClearDevToolsLocalStorage)

IPC_MESSAGE_HANDLER(ShellViewHostMsg_ShowDevTools, OnShowDevTools)

+ IPC_MESSAGE_HANDLER(ShellViewHostMsg_EvaluateInDevTools,

+ OnEvaluateInDevTools)

IPC_MESSAGE_HANDLER(ShellViewHostMsg_CloseDevTools, OnCloseDevTools)

IPC_MESSAGE_HANDLER(ShellViewHostMsg_GoToOffset, OnGoToOffset)

IPC_MESSAGE_HANDLER(ShellViewHostMsg_Reload, OnReload)

@@ -766,6 +768,12 @@ void BlinkTestController::OnShowDevTools(const std::string& settings,

devtools_frontend_->Focus();

}

+void BlinkTestController::OnEvaluateInDevTools(

+ int call_id, const std::string& script) {

+ if (devtools_frontend_)

+ devtools_frontend_->EvaluateInFrontend(call_id, script);

void BlinkTestController::OnCloseDevTools() {

if (devtools_frontend_)

devtools_frontend_->DisconnectFromTarget();