Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 1819223002: Mojom frontend: Allow non-reference types in non-zero versions of a struct. (Closed)

Created:
4 years, 9 months ago by rudominer
Modified:
4 years, 9 months ago
Reviewers:
azani
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Mojom frontend: Allow non-reference types in non-zero versions of a struct. https://codereview.chromium.org/1823563002/ erroneously disallowed non-reference types in non-zero versions of a struct. This patch rectifies this problem, adds a test for it, and adds new sha1s and new generated .mojom.dart files. - We added the method AllowedInNonZeroStructVersion() to the TypeReference interface and we invoke that instead of the Nullable() method in computeVersionInfo(). - We moved StructFieldMinVersionError from user_defined_types.go to computed_data.go where it belongs. BUG=#713 R=azani@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/9453c00348e8b8de237c8228e659e212dafb2b93

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -92 lines) Patch
M mojo/dart/packages/_mojo_for_test_only/lib/dart_to_cpp/dart_to_cpp.mojom.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/imported/sample_import.mojom.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/imported/sample_import2.mojom.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/math/math_calculator.mojom.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/mojo/examples/echo.mojom.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/mojo/test/rect.mojom.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/mojo/test/serialization_test_structs.mojom.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/mojo/test/test_enums.mojom.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/mojo/test/test_included_unions.mojom.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/mojo/test/test_structs.mojom.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/mojo/test/test_unions.mojom.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/mojo/test/validation_test_interfaces.mojom.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/mojo/test/versioning/versioning_test_client.mojom.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/regression_tests/regression_tests.mojom.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/sample/sample_factory.mojom.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/sample/sample_interfaces.mojom.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/sample/sample_service.mojom.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/test/echo_service.mojom.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/test/pingpong_service.mojom.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/tools/bindings/mojom_tool/bin/linux64/mojom.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/tools/bindings/mojom_tool/bin/mac64/mojom.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M mojom/mojom_parser/mojom/computed_data.go View 3 chunks +66 lines, -1 line 0 comments Download
M mojom/mojom_parser/mojom/types.go View 7 chunks +35 lines, -4 lines 0 comments Download
M mojom/mojom_parser/mojom/user_defined_types.go View 1 chunk +0 lines, -63 lines 0 comments Download
M mojom/mojom_parser/parser/computed_data_test.go View 1 chunk +1 line, -1 line 0 comments Download
M mojom/mojom_parser/serialization/serialization_test.go View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
rudominer
Hi Alex, ptal.
4 years, 9 months ago (2016-03-22 00:47:04 UTC) #4
azani
lgtm
4 years, 9 months ago (2016-03-22 14:48:20 UTC) #5
rudominer
4 years, 9 months ago (2016-03-22 15:39:37 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9453c00348e8b8de237c8228e659e212dafb2b93 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698