mojom/mojom_parser/serialization/serialization_test.go - Issue 1819223002: Mojom frontend: Allow non-reference types in non-zero versions of a struct.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojom/mojom_parser/serialization/serialization_test.go

Issue 1819223002: Mojom frontend: Allow non-reference types in non-zero versions of a struct. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: mojom/mojom_parser/serialization/serialization_test.go

diff --git a/mojom/mojom_parser/serialization/serialization_test.go b/mojom/mojom_parser/serialization/serialization_test.go

index c4f1d3ce9d734fe12be3f21a03deb77d12e4fd02..baf834c57399bd8eb6d3a3db5a7dd47f2a3affc9 100644

--- a/mojom/mojom_parser/serialization/serialization_test.go

+++ b/mojom/mojom_parser/serialization/serialization_test.go

@@ -1962,7 +1962,7 @@ func TestWithComputedData(t *testing.T) {

MyInterface1&? my_interface_request;

[MinVersion=2]

- handle? y;

+ int32 y;

[MinVersion=2]

MyInterface1? my_interface;

@@ -2011,7 +2011,7 @@ func TestWithComputedData(t *testing.T) {

// field y

{

DeclData: test.newShortDeclDataAO(4, -1, "y", &[]mojom_types.Attribute{{"MinVersion", &mojom_types.LiteralValueInt8Value{2}}}),

- Type: &mojom_types.TypeHandleType{mojom_types.HandleType{Nullable: true}},

+ Type: &mojom_types.TypeSimpleType{mojom_types.SimpleType_Int32},

Offset: 32,

MinVersion: 2,

« no previous file with comments | « mojom/mojom_parser/parser/computed_data_test.go ('k') | no next file » | no next file with comments »