Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Unified Diff: chrome/browser/extensions/platform_app_browsertest.cc

Issue 18192003: Add tests for ShellWindowLinkDelegate::OpenURLFromTab (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/platform_app_browsertest.cc
diff --git a/chrome/browser/extensions/platform_app_browsertest.cc b/chrome/browser/extensions/platform_app_browsertest.cc
index 03b046cdc7814b4fc4a2659d3895179c050e2d04..075d1cddcbd4139dbacf01a7a2b0c6afc3ebc013 100644
--- a/chrome/browser/extensions/platform_app_browsertest.cc
+++ b/chrome/browser/extensions/platform_app_browsertest.cc
@@ -605,6 +605,15 @@ IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest, GetDisplayPath) {
<< message_;
}
+// Test that ShellWindowLinkDelegate::OpenURLFromTab doesn't crash. This code
+// relies on the WebContents implementation not dereferencing the Source
+// WebContents after ShellWindowLinkDelegate frees it.
+IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest, ExternalOpenLink) {
+ ShellWindow::EnableExternalOpenForTesting();
+ ASSERT_TRUE(RunPlatformAppTest("platform_apps/external_open_link"));
+ ShellWindow::DisableExternalOpenForTesting();
+}
+
#endif // defined(OS_CHROMEOS)
IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest, OpenLink) {
« no previous file with comments | « no previous file | chrome/browser/ui/extensions/shell_window.h » ('j') | chrome/browser/ui/extensions/shell_window.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698