Add tests for ShellWindowLinkDelegate::OpenURLFromTab

chrome/browser/extensions/platform_app_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/file_util.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/prefs/pref_service.h"
 #include "base/stl_util.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 587 matching lines @@
 }
 
 // Test that platform apps can use the chrome.fileSystem.getDisplayPath
 // function to get the native file system path of a file they are launched with.
 IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest, GetDisplayPath) {
   SetCommandLineArg(kTestFilePath);
   ASSERT_TRUE(RunPlatformAppTest("platform_apps/get_display_path"))
       << message_;
 }
 
+// Test that ShellWindowLinkDelegate::OpenURLFromTab doesn't crash. This code
+// relies on the WebContents implementation not dereferencing the Source
+// WebContents after ShellWindowLinkDelegate frees it.
+IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest, ExternalOpenLink) {
+  ShellWindow::EnableExternalOpenForTesting();
+  ASSERT_TRUE(RunPlatformAppTest("platform_apps/external_open_link"));
+  ShellWindow::DisableExternalOpenForTesting();
+}
+
 #endif  // defined(OS_CHROMEOS)
 
 IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest, OpenLink) {
   ASSERT_TRUE(StartEmbeddedTestServer());
   content::WindowedNotificationObserver observer(
       chrome::NOTIFICATION_TAB_ADDED,
       content::Source<content::WebContentsDelegate>(browser()));
   LoadAndLaunchPlatformApp("open_link");
   observer.Wait();
   ASSERT_EQ(2, browser()->tab_strip_model()->count());
@@ skipping 459 matching lines @@
 
   while (!ContainsKey(opener_app_ids_, file_manager->id())) {
     content::RunAllPendingInMessageLoop();
   }
 }
 
 #endif  // defined(OS_CHROMEOS)
 
 
 }  // namespace extensions