Issue 1819023002: Merge M50: "Supress pipeline errors during destruction and suspend."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1819023002: Merge M50: "Supress pipeline errors during destruction and suspend." (Closed)

Created:
4 years, 9 months ago by DaleCurtis

Modified:
4 years, 9 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2661

Target Ref:
refs/pending/branch-heads/2661

Project:
chromium

Visibility:
Public.

Merge M50: "Supress pipeline errors during destruction and suspend." These errors either don't matter or will be recovered naturally the next time the player is interacted with. We should not count these towards our failure rates. BUG=591244 TEST=modified unittests. Review URL: https://codereview.chromium.org/1753043002 Cr-Commit-Position: refs/heads/master@{#378916} (cherry picked from commit 2ff781da56aa95ad5bb8be9075abf97cf26c82aa) Committed: https://chromium.googlesource.com/chromium/src/+/5792075b8b5267e8f9a29a90b2c6b240891a7761

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+60 lines, -52 lines)			Patch
M	media/base/demuxer.h	View	1 chunk	+5 lines, -2 lines	0 comments	Download
M	media/base/pipeline_impl.cc	View	1 chunk	+9 lines, -3 lines	0 comments	Download
M	media/base/pipeline_impl_unittest.cc	View	3 chunks	+33 lines, -46 lines	0 comments	Download
M	media/blink/webmediaplayer_impl.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	media/blink/webmediaplayer_impl.cc	View	3 chunks	+8 lines, -1 line	0 comments	Download

Total messages: 2 (1 generated)

DaleCurtis

4 years, 9 months ago (2016-03-21 17:50:17 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
5792075b8b5267e8f9a29a90b2c6b240891a7761.