Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 1753043002: Supress pipeline errors during destruction and suspend. (Closed)

Created:
4 years, 9 months ago by DaleCurtis
Modified:
4 years, 9 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Supress pipeline errors during destruction and suspend. These errors either don't matter or will be recovered naturally the next time the player is interacted with. We should not count these towards our failure rates. BUG=591244 TEST=modified unittests. Committed: https://crrev.com/2ff781da56aa95ad5bb8be9075abf97cf26c82aa Cr-Commit-Position: refs/heads/master@{#378916}

Patch Set 1 #

Patch Set 2 : Comments. #

Patch Set 3 : Fix comment style. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -52 lines) Patch
M media/base/demuxer.h View 1 2 1 chunk +5 lines, -2 lines 0 comments Download
M media/base/pipeline_impl.cc View 1 2 1 chunk +9 lines, -3 lines 0 comments Download
M media/base/pipeline_impl_unittest.cc View 3 chunks +33 lines, -46 lines 0 comments Download
M media/blink/webmediaplayer_impl.h View 1 chunk +5 lines, -0 lines 0 comments Download
M media/blink/webmediaplayer_impl.cc View 1 3 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
DaleCurtis
4 years, 9 months ago (2016-03-02 00:51:25 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1753043002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1753043002/1
4 years, 9 months ago (2016-03-02 01:24:43 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-02 03:53:04 UTC) #6
DaleCurtis
PTAL, updated the comments per our chat.
4 years, 9 months ago (2016-03-03 00:01:24 UTC) #7
sandersd (OOO until July 31)
lgtm
4 years, 9 months ago (2016-03-03 00:16:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1753043002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1753043002/40001
4 years, 9 months ago (2016-03-03 00:18:42 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-03 01:52:24 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-03 01:55:02 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2ff781da56aa95ad5bb8be9075abf97cf26c82aa
Cr-Commit-Position: refs/heads/master@{#378916}

Powered by Google App Engine
This is Rietveld 408576698