Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 1818963003: Pass nullptr for paintInvalidationState if it can't be used to map geometry. (Closed)

Created:
4 years, 9 months ago by chrishtr
Modified:
4 years, 9 months ago
Reviewers:
Xianzhu
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, krit, eae+blinkwatch, f(malita), fs, gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Pass nullptr for paintInvalidationState if it can't be used to map geometry. If it can't be used for the current object, it can't be used for an ancestor. Therefore, after it returning false for canMapToAncestor(), pass nullptr fur further recursions up the layout tree. Furthermore, using it for an ancestor is invalid because a PaintInvalidationState object is bound to a single LayoutObject. Also adds PaintInvalidationState early-outing to LayoutView. BUG=594516 Committed: https://crrev.com/4e57e854bd3a3e47c4aa18ce934d838e4eed4030 Cr-Commit-Position: refs/heads/master@{#382772}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -8 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutInline.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutView.cpp View 1 2 2 chunks +5 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (9 generated)
chrishtr
I found this when working on the referenced bug.
4 years, 9 months ago (2016-03-22 02:43:09 UTC) #5
Xianzhu
LGTM. I'm working on a bigger change to move all fast path paint invalidation mapping ...
4 years, 9 months ago (2016-03-22 16:41:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1818963003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1818963003/40001
4 years, 9 months ago (2016-03-22 17:55:42 UTC) #9
chrishtr
Turns out PaintInvalidationState doesn't work yet for LayoutView, added a TODO for that.
4 years, 9 months ago (2016-03-22 17:55:54 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/200368)
4 years, 9 months ago (2016-03-22 20:59:29 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1818963003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1818963003/40001
4 years, 9 months ago (2016-03-23 01:11:01 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-23 02:18:05 UTC) #15
commit-bot: I haz the power
4 years, 9 months ago (2016-03-23 02:19:45 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4e57e854bd3a3e47c4aa18ce934d838e4eed4030
Cr-Commit-Position: refs/heads/master@{#382772}

Powered by Google App Engine
This is Rietveld 408576698