third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp - Issue 1818963003: Pass nullptr for paintInvalidationState if it can't be used to map geometry.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp

Issue 1818963003: Pass nullptr for paintInvalidationState if it can't be used to map geometry. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutView.cpp ('k') | third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp

diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp b/third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp

index c99a72bcced8793c89edb043092ba7b2cb33d0c5..259d6f39208de78b9e14c3ad9b23a437dfa335e8 100644

--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp

+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp

@@ -236,7 +236,7 @@ LayoutRect LayoutSVGInlineText::clippedOverflowRectForPaintInvalidation(const La

// FIXME: The following works because LayoutSVGBlock has forced slow rect mapping of the paintInvalidationState.

// Should let this really work with paintInvalidationState's fast mapping and remove the assert.

ASSERT(!paintInvalidationState || !paintInvalidationState->canMapToAncestor(paintInvalidationContainer));

- return parent()->clippedOverflowRectForPaintInvalidation(paintInvalidationContainer, paintInvalidationState);

+ return parent()->clippedOverflowRectForPaintInvalidation(paintInvalidationContainer, nullptr);

}

PassRefPtr<StringImpl> LayoutSVGInlineText::originalText() const