Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 1818883003: Fix --trace-isolates VM crash. (Closed)

Created:
4 years, 9 months ago by Florian Schneider
Modified:
4 years, 8 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix --trace-isolates VM crash. Thread::Current() is NULL when shutting down, causing a seg fault when executing thread()->sticky_error(). BUG= R=srdjan@google.com Committed: https://github.com/dart-lang/sdk/commit/dd72d74964aba797adac8b8ea00625595a8f1b3f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M runtime/vm/message_handler.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Florian Schneider
4 years, 9 months ago (2016-03-21 13:52:54 UTC) #2
srdjan
lgtm
4 years, 8 months ago (2016-03-30 17:49:16 UTC) #3
Florian Schneider
4 years, 8 months ago (2016-03-30 23:35:15 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
dd72d74964aba797adac8b8ea00625595a8f1b3f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698